Add rib subscription API.
ClosedPublic
Actions

Authored by melifaro on May 30 2020, 2:47 PM.

Details

Reviewers

Group Reviewers

network

Commits

rS361708: Add rib subscription API.

Summary

Currently there is no easy way of subscribing for the routing table changes. The only existing way is to set ifa_rtrequest callback in the each protocol ifaddr, which is not convenient or extandable.

This change provides generic notification subscription mechanism, that will replace current ifa_rtrequest one and allow other applications such as accelerated routing lookup modules subscribe for the changes.

In particular, this change provides 2 hooks: 1) synchronous one (RIB_NOTIFY_IMMEDIATE), called under RIB_WLOCK, which ensures exact ordering of the changes and 2) async one, (RIB_NOTIFY_DELAYED) that is called after the change w/o holding locks. The latter one does not provide any notification ordering guarantee.

This change depends on D25067.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31403
Build 29026: arc lint + arc unit

Event Timeline

melifaro created this revision.May 30 2020, 2:47 PM

Herald added a subscriber: ae. · View Herald TranscriptMay 30 2020, 2:47 PM

melifaro requested review of this revision.May 30 2020, 2:47 PM

Harbormaster completed remote builds in B31394: Diff 72449.May 30 2020, 2:47 PM

melifaro edited the summary of this revision. (Show Details)May 30 2020, 2:55 PM

melifaro added reviewers: network, ae.

melifaro edited the summary of this revision. (Show Details)

melifaro added a parent revision: D25067: add new rib manipulation functions..

Add forgottech epoch reclamation.

Harbormaster completed remote builds in B31403: Diff 72468.May 31 2020, 7:40 AM

How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?

In D25070#552529, @ae wrote:

How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?

Currently there is only one - ND6 default route checker. With the modular lookup engine, there will be 1 more for rtables where lookup engine is attached.
With that in mind, idea is to start with the simplest implementation and then enhance it if/when needed.

melifaro mentioned this in rS361705: Revert r361704, it accidentally committed merged D25067 and D25070..Jun 1 2020, 8:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2020, 9:52 PM

Closed by commit rS361708: Add rib subscription API. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS361708: Add rib subscription API..

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2020, 9:52 PM