fix sosend() so that it can handle an mbuf list for KTLS
ClosedPublic
Actions

Authored by rmacklem on May 2 2020, 11:30 PM.

Details

Reviewers

gallatin
jhb
glebius

Commits

rS361567: Fix sosend() for the case where mbufs are passed in while doing ktls.

Summary

When the nfs-over-tls krpc calls sosend() with a list of ext_pgs
mbufsto be handled via the ktls, ktls_frame() needs to be
called on them.

This patch just does the same call as the case where the data
has been copied in via m_uiotombuf() below where the patch
is applied.

I'll admit I don't understand if/when tls_rtype is not TLS_RLTYPE_APP,
but I did what the m_uiotombuf() case already does.

Test Plan

It has seen minimal testing using nfs-over-tls sofar,
but I will be doing further testing soon.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.May 2 2020, 11:30 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 2 2020, 11:30 PM

rmacklem requested review of this revision.May 2 2020, 11:30 PM

Harbormaster completed remote builds in B30873: Diff 71302.May 2 2020, 11:30 PM

rmacklem added a reviewer: glebius.May 27 2020, 12:40 AM

This looks correct to me.

This revision is now accepted and ready to land.May 27 2020, 12:52 AM

gallatin accepted this revision.May 27 2020, 3:48 AM

Closed by commit rS361567: Fix sosend() for the case where mbufs are passed in while doing ktls. (authored by rmacklem). · Explain WhyMay 27 2020, 11:21 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rS361567: Fix sosend() for the case where mbufs are passed in while doing ktls..

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

uipc_socket.c

7 lines

Diff 72344

View Options

head/sys/kern/uipc_socket.c

fix sosend() so that it can handle an mbuf list for KTLSClosedPublicActions