Differential D24978

Switch gif(4) path verification to use fib[46]_check_urfp()
ClosedPublic
Actions

Authored by melifaro on May 23 2020, 5:36 PM.

Details

Reviewers

Group Reviewers

network

Commits

rS361572: Switch gif(4) path verification to fib[46]_check_urfp().

Summary

fibX_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.
Use specialized fib[46]_check_urpf() from newer KPI instead,
to allow removal of older KPI.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31261
Build 28907: arc lint + arc unit

Event Timeline

melifaro created this revision.May 23 2020, 5:36 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptMay 23 2020, 5:36 PM

Harbormaster completed remote builds in B31261: Diff 72169.May 23 2020, 5:36 PM

melifaro requested review of this revision.May 23 2020, 5:36 PM

ae accepted this revision.May 26 2020, 10:48 AM

This revision is now accepted and ready to land.May 26 2020, 10:48 AM

Closed by commit rS361572: Switch gif(4) path verification to fib[46]_check_urfp(). (authored by melifaro). · Explain WhyMay 28 2020, 7:26 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS361572: Switch gif(4) path verification to fib[46]_check_urfp()..

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_gif.c

9 lines

netinet6/

in6_gif.c

10 lines

Diff 72169

View Options

sys/netinet/in_gif.c