Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 31231 Build 28881: arc lint + arc unit
Event Timeline
Pass SOURCE_DATE_EPOCH in build environnement if the timestamp is
defined in the distinfo
I remember a review by @emaste (I think) about this, he had a default value for the TIMESTAMP.
Yes the initial patch was: https://people.freebsd.org/~bapt/reproduciblebuild.diff
I decided in the version to drop the default TIMESTAMP as it can generate failures on packages, and prefer to only have reproducibility on packages having a timestamp (most of them should have now)
I was wondering about ports without a distinfo file (like, say, ports-mgmt/portlint) but they could gain a distinfo file with only a TIMESTAMP in it.
| Mk/bsd.port.mk | ||
|---|---|---|
| 2049 | Maybe this should be in a .else for the next .if. | |
| 2051 | Can you cache this using the usual mechanism so that we do not run awk in each submake? | |
Seems reasonable as a first step. Do we address the python issue with this change?
| Mk/bsd.port.mk | ||
|---|---|---|
| 2049 | I think it's because we want it to be 0 also if DISTINFO_FILE exists but does not have a TIMESTAMP line | |
Mark python < 3.7 as not reproducible with the new NOT_REPRODUCIBLE knob
Cache the timestamp
I'd like to take over this patch and the previous one at D4385 to help push this in. I am also currently building some tooling around Poudriere to help verify reproducibilty across the ports tree. Have there been any more recent discussions around implementing SOURCE_DATE_EPOCH in the Ports tree other than these two Phabricator reviews? If not, I'll start testing this and working on the feedback, then resubmit a v2.