Paths

Table of Contentst

Differential D24870

Move <add|del|change>_route to route_ctl.c
ClosedPublic
Actions

Authored by melifaro on May 17 2020, 10:04 AM.

Tags

None

Referenced Files

	F173204350: D24870.diff
	Thu, Sep 24, 7:03 AM

	Unknown Object (File)
	Sun, Sep 13, 4:42 PM

	Unknown Object (File)
	Sun, Sep 13, 12:59 AM

	Unknown Object (File)
	Sat, Sep 12, 7:45 PM

	Unknown Object (File)
	Sat, Sep 12, 2:15 PM

	Unknown Object (File)
	Sat, Sep 12, 8:17 AM

	Unknown Object (File)
	Sat, Sep 5, 9:32 PM

	Unknown Object (File)
	Fri, Sep 4, 1:54 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rS361421: Move <add|del|change>_route() functions to route_ctl.c in preparation of

Summary

Move <add|del|change>_route() functions to route_ctl.c in preparation of multipath control plane changed described in D24141.

Currently route.c contains core routing init/teardown functions, route table manipulation functions and various helper functions, resulting in >2KLOC file in total. This change moves most of the route table manipulation parts to a dedicated file, simplifying planned multipath changes and making route.c more manageable.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31132
Build 28815: arc lint + arc unit

Event Timeline

melifaro created this revision.May 17 2020, 10:04 AM

Herald added a subscriber: ae. · View Herald TranscriptMay 17 2020, 10:04 AM

melifaro requested review of this revision.May 17 2020, 10:04 AM

Harbormaster completed remote builds in B31132: Diff 71885.May 17 2020, 10:04 AM

melifaro edited the summary of this revision. (Show Details)May 17 2020, 10:12 AM

Leave rtrequest1_fib() in route.c

Harbormaster completed remote builds in B31133: Diff 71886.May 17 2020, 10:16 AM

melifaro added a reviewer: network.May 17 2020, 10:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2020, 7:07 PM

Closed by commit rS361421: Move <add|del|change>_route() functions to route_ctl.c in preparation of (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS361421: Move <add|del|change>_route() functions to route_ctl.c in preparation of.

Herald added subscribers: bz, imp. · View Herald TranscriptMay 23 2020, 7:07 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

4 lines

646 lines

route/

588 lines

19 lines

9 lines

netinet/

1 line

netinet6/

1 line

Diff 71885

sys/net/if_var.h

Loading...

sys/net/route.c

Loading...

sys/net/route/route_ctl.c

Loading...

sys/net/route/route_var.h

Loading...

sys/net/route/shared.h

Loading...

sys/netinet/in_fib.c

Loading...

sys/netinet6/in6_fib.c

Loading...