Details
Details
- Reviewers
- None
- Group Reviewers
network
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30884 Build 28600: arc lint + arc unit
Event Timeline
Comment Actions
Hi Kristof,
Thank you for looking into the routing api! :-)
I have a couple of comments on this one:
- indeed, rib_lookup_info() does not use flowid, as our multipath support is far from perfect. D24141 is intended to address that. Half of its changes has been merged already.
- There are (and there will be) number of places in kernel where one needs to lookup both the found prefix and nexthop data. Given nexthop objects availability, such lookup function can be simplified to return prefix and nexthop object, w/o requiring passing rt_addrinfo and using costy refcounts. Additionally, upcoming multipath support will remove the requirement of supporting non-contiguous mask, allowing to return mask length instead of sockaddr with mask. In fact, I'm going to introduce such function soon and replace ipfw(4) lookup calls and rib_lookup_info() calls with that function.
With that in mind, I'm not sure if it's worth removing the currently unused argument right now :-)
Comment Actions
Fair enough. I have no immediate plans to dig deeper into this part of the code. I'd run into this a while back, and figured it made sense to remove unused arguments. I finally got around to this particular item on my todo list. If there's pending work that'll rely on it that's clearly not a good idea at this point.