Page MenuHomeFreeBSD
Differential D24536

Don't try ctfconvert on file without debug info.
ClosedPublic
Actions

Authored by bdrewery on Apr 22 2020, 7:00 PM.
Tags
None
Referenced Files
F142220267: D24536.diff
Sat, Jan 17, 10:17 AM
Unknown Object (File)
Fri, Jan 2, 8:19 PM
Unknown Object (File)
Dec 9 2025, 9:48 AM
Unknown Object (File)
Nov 20 2025, 11:40 AM
Unknown Object (File)
Nov 20 2025, 11:15 AM
Unknown Object (File)
Nov 20 2025, 11:15 AM
Unknown Object (File)
Nov 20 2025, 11:14 AM
Unknown Object (File)
Nov 20 2025, 11:14 AM
View All Files
Subscribers
None

Details

Reviewers
imp
cem
markj
Commits
rS360444: Don't try ctfconvert on file without debug info.
Summary

This was currently an ignored error but will change to a hard error
eventually.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30706
Build 28436: arc lint + arc unit

Event Timeline

bdrewery created this revision.Apr 22 2020, 7:00 PM
Harbormaster completed remote builds in B30667: Diff 70886.Apr 22 2020, 7:00 PM
bdrewery added a parent revision: D24535: config: Add no-ctfconvert support..Apr 22 2020, 7:01 PM
bdrewery mentioned this in D24537: ctfmerge: Assert that there is enough room for types..Apr 22 2020, 7:07 PM
bdrewery added a child revision: D24537: ctfmerge: Assert that there is enough room for types..Apr 22 2020, 7:08 PM
markj accepted this revision.Apr 22 2020, 7:10 PM
This revision is now accepted and ready to land.Apr 22 2020, 7:10 PM
cem accepted this revision.Apr 23 2020, 2:18 AM
bdrewery updated this revision to Diff 70950.Apr 24 2020, 5:23 PM

bump required version

This revision now requires review to proceed.Apr 24 2020, 5:23 PM
Harbormaster completed remote builds in B30705: Diff 70950.Apr 24 2020, 5:23 PM
cem added inline comments.Apr 24 2020, 5:35 PM
sys/conf/Makefile.amd64
21

Wasn't it 18 in the other file?

bdrewery added inline comments.Apr 24 2020, 6:03 PM
sys/conf/Makefile.amd64
21

I'm an idiot

bdrewery updated this revision to Diff 70952.Apr 24 2020, 6:04 PM

Use proper version

Harbormaster completed remote builds in B30706: Diff 70952.Apr 24 2020, 6:04 PM
cem accepted this revision.Apr 24 2020, 6:11 PM
This revision is now accepted and ready to land.Apr 24 2020, 6:11 PM
Closed by commit rS360444: Don't try ctfconvert on file without debug info. (authored by bdrewery). · Explain WhyApr 28 2020, 4:09 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rS360444: Don't try ctfconvert on file without debug info..

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
3 lines

Diff 70952

View Options

sys/conf/Makefile.amd64

Loading...
View Options

sys/conf/files.amd64

Loading...