Don't try ctfconvert on file without debug info.
ClosedPublic
Actions

Authored by bdrewery on Apr 22 2020, 7:00 PM.

Details

Reviewers

imp
cem
markj

Commits

rS360444: Don't try ctfconvert on file without debug info.

Summary

This was currently an ignored error but will change to a hard error
eventually.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bdrewery created this revision.Apr 22 2020, 7:00 PM

Harbormaster completed remote builds in B30667: Diff 70886.Apr 22 2020, 7:00 PM

bdrewery added a parent revision: D24535: config: Add no-ctfconvert support..Apr 22 2020, 7:01 PM

bdrewery mentioned this in D24537: ctfmerge: Assert that there is enough room for types..Apr 22 2020, 7:07 PM

bdrewery added a child revision: D24537: ctfmerge: Assert that there is enough room for types..Apr 22 2020, 7:08 PM

markj accepted this revision.Apr 22 2020, 7:10 PM

This revision is now accepted and ready to land.Apr 22 2020, 7:10 PM

cem accepted this revision.Apr 23 2020, 2:18 AM

bump required version

This revision now requires review to proceed.Apr 24 2020, 5:23 PM

Harbormaster completed remote builds in B30705: Diff 70950.Apr 24 2020, 5:23 PM

cem added inline comments.Apr 24 2020, 5:35 PM

sys/conf/Makefile.amd64
21 ↗	(On Diff #70950)	Wasn't it 18 in the other file?

bdrewery added inline comments.Apr 24 2020, 6:03 PM

sys/conf/Makefile.amd64
21 ↗	(On Diff #70950)	I'm an idiot

Use proper version

Harbormaster completed remote builds in B30706: Diff 70952.Apr 24 2020, 6:04 PM

cem accepted this revision.Apr 24 2020, 6:11 PM

This revision is now accepted and ready to land.Apr 24 2020, 6:11 PM

Closed by commit rS360444: Don't try ctfconvert on file without debug info. (authored by bdrewery). · Explain WhyApr 28 2020, 4:09 PM

This revision was automatically updated to reflect the committed changes.

bdrewery added a commit: rS360444: Don't try ctfconvert on file without debug info..

Revision Contents
Changeset List

Path

Size

head/

sys/

conf/

Makefile.amd64

2 lines

files.amd64

3 lines

Diff 71111

View Options

head/sys/conf/Makefile.amd64