Page MenuHomeFreeBSD
Differential D24540

Update blake2 accelerated software tests to work after OCF refactoring.
ClosedPublic
Actions

Authored by jhb on Apr 22 2020, 7:27 PM.
Tags
None
Referenced Files
F154654422: D24540.id70892.diff
Wed, Apr 29, 3:40 AM
F154447923: D24540.id70894.diff
Tue, Apr 28, 3:23 PM
F154397360: D24540.id70890.diff
Tue, Apr 28, 8:25 AM
Unknown Object (File)
Mon, Apr 27, 4:38 PM
Unknown Object (File)
Mon, Apr 27, 3:42 PM
Unknown Object (File)
Mon, Apr 27, 2:30 PM
Unknown Object (File)
Mon, Apr 27, 7:33 AM
Unknown Object (File)
Mon, Apr 27, 3:30 AM
View All Files
Subscribers
cem
imp

Details

Reviewers
lwhsu
jmg
cem
Commits
rS360203: Update blake2 accelerated software tests to work after OCF refactoring.
Summary
  • Lookup device drivers to test by name instead of assuming that the software / hardware flags will select specific drivers.
  • Set the sysctl to permit software /dev/crypto requests when testing the accelerated software blake2 driver.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30671
Build 28406: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 22 2020, 7:27 PM
Herald added a reviewer: jmg. · View Herald TranscriptApr 22 2020, 7:27 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B30671: Diff 70890.Apr 22 2020, 7:27 PM
cem accepted this revision.Apr 22 2020, 7:34 PM
cem added a subscriber: cem.
cem added inline comments.
tests/sys/opencrypto/blake2_test.c
149

I’d prefer to do the lookup_crid on a statement of its own. Just a style nit.

This revision is now accepted and ready to land.Apr 22 2020, 7:34 PM
jhb updated this revision to Diff 70892.Apr 22 2020, 7:46 PM
jhb marked an inline comment as done.
  • Move lookup_crid to separate lines.
This revision now requires review to proceed.Apr 22 2020, 7:46 PM
Harbormaster completed remote builds in B30672: Diff 70892.Apr 22 2020, 7:46 PM
cem accepted this revision.Apr 22 2020, 7:50 PM

Thanks!

This revision is now accepted and ready to land.Apr 22 2020, 7:50 PM
lwhsu accepted this revision.Apr 22 2020, 7:52 PM

Verified tests pass after applying the patch.

Closed by commit rS360203: Update blake2 accelerated software tests to work after OCF refactoring. (authored by jhb). · Explain WhyApr 22 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS360203: Update blake2 accelerated software tests to work after OCF refactoring..

Revision Contents
Changeset List

PathSize
tests/
sys/
opencrypto/
37 lines

Diff 70890

View Options

tests/sys/opencrypto/blake2_test.c

Loading...