Page MenuHomeFreeBSD
Differential D24231

[NEW FEATURE] print-gh-tuple: Print GH_TUPLE corresponding to submodules of a GitHub repository ${GH_ACCOUNT}/${GH_PROJECT}
Needs ReviewPublic
Actions

Authored by yuri on Mar 30 2020, 8:54 PM.
Tags
None
Referenced Files
F161075928: D24231.id70024.diff
Tue, Jun 30, 8:58 AM
F161048287: D24231.id70789.diff
Tue, Jun 30, 3:15 AM
F160988566: D24231.diff
Mon, Jun 29, 3:53 PM
Unknown Object (File)
Sun, Jun 28, 6:26 PM
Unknown Object (File)
Sat, Jun 27, 7:41 PM
Unknown Object (File)
Sat, Jun 27, 8:20 AM
Unknown Object (File)
Thu, Jun 25, 6:19 AM
Unknown Object (File)
Tue, Jun 23, 9:49 PM
View All Files
Subscribers
0mp
mat
pi
rhurlin
risner_stdio.com
val_packett.cool
Contributor Reviewers (ports)

Details

Reviewers
None
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Summary

The attached patch defines the new target make print-gh-tuple that prints GH_TUPLE for all git submodules of the default Git repository ${GH_ACCOUNT}/${GH_PROJECT} when USE_GITHUB=yes is set.

Purpose: Simplify creation of the GH_TARGET tag when the repository has a lot of submodules.

It traverses and returns all submodules hierarchically.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

yuri created this revision.Mar 30 2020, 8:54 PM
Herald added a reviewer: portmgr. · View Herald TranscriptMar 30 2020, 8:54 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript
yuri edited the summary of this revision. (Show Details)Mar 30 2020, 8:55 PM
yuri retitled this revision from [NEW FEATURE] print-gh-tuple: Print GH_TUPLE corresponding to the submodules in a GitHub repository ${GH_ACCOUNT}/${GH_PROJECT} to [NEW FEATURE] print-gh-tuple: Print GH_TUPLE corresponding to submodules of a GitHub repository ${GH_ACCOUNT}/${GH_PROJECT}.
yuri removed 1 blocking reviewer(s): portmgr.
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptMar 30 2020, 8:56 PM
yuri updated this revision to Diff 70034.Mar 30 2020, 10:01 PM
val_packett.cool added a subscriber: val_packett.cool.Mar 31 2020, 4:21 PM
yuri updated this revision to Diff 70642.Apr 16 2020, 4:22 PM
pi added a subscriber: pi.Apr 16 2020, 6:26 PM
0mp added a subscriber: 0mp.Apr 17 2020, 7:35 AM
rhurlin added a subscriber: rhurlin.Apr 17 2020, 7:50 AM
mat added a comment.Apr 18 2020, 10:24 AM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

mat added a comment.Apr 18 2020, 12:02 PM

Also, can you extract the awk script to is own file?

yuri updated this revision to Diff 70748.Apr 18 2020, 8:15 PM
yuri edited the summary of this revision. (Show Details)
yuri edited the test plan for this revision. (Show Details)

Update the patch with arcanist.

Owners added a reviewer: O5: Ports Framework.Apr 18 2020, 8:15 PM
Harbormaster completed remote builds in B30594: Diff 70748.Apr 18 2020, 8:15 PM
yuri added a comment.Apr 18 2020, 8:18 PM
In D24231#538538, @mat wrote:

Also, can you extract the awk script to is own file?

Currently no extra files are created by this feature, except for the git repository being cloned, which is necessary.
The feature works in a stream fashion, and there would be no benefit in saving the intermediate output into extra files. For debugging | tee /tmp/awk-input.txt can be added.

Why do you want to save the output into a file?

yuri updated this revision to Diff 70749.Apr 18 2020, 8:20 PM

Update.

Harbormaster completed remote builds in B30595: Diff 70749.Apr 18 2020, 8:20 PM
yuri added a comment.Apr 18 2020, 8:33 PM

audio/surge-synthesizer-lv2 can be used as a testcase.

mat added a comment.Apr 19 2020, 2:25 PM
In D24231#538638, @yuri wrote:

Why do you want to save the output into a file?

Something got lost in translation.

Also, can you extract the awk script to is own file?

The Mk/Scripts/print-submodule-gh_tuple.sh file is about 15 lines of shell and 60 lines of awk, please put the awk script into its own file.

yuri updated this revision to Diff 70788.Apr 19 2020, 6:52 PM

Move the awk code into a separate file.

Harbormaster completed remote builds in B30615: Diff 70788.Apr 19 2020, 6:52 PM
yuri updated this revision to Diff 70789.Apr 19 2020, 6:55 PM

Update

Harbormaster completed remote builds in B30616: Diff 70789.Apr 19 2020, 6:55 PM
yuri added a comment.Apr 29 2020, 5:23 PM

Anything else needs to be changed?

I used print-gh-tuple on multiple ports and it worked as expected.

0mp added a comment.Apr 18 2021, 3:02 PM

Are you still using this to work on your ports?

Mk/Scripts/print-submodule-gh_tuple.awk
2 ↗(On Diff #70789)

No needed anymore.

Mk/Scripts/print-submodule-gh_tuple.sh
16

Should we set set -o pipefail here for consistency with other scripts?

yuri added a comment.Apr 18 2021, 5:45 PM
In D24231#669073, @0mp wrote:

Are you still using this to work on your ports?

Yes, I used it on many ports. I am going to update the patch with bugfixes, and will incorporate your suggestions.

risner_stdio.com added a subscriber: risner_stdio.com.Dec 30 2021, 1:34 PM
In D24231#669073, @0mp wrote:

Are you still using this to work on your ports?

I haven't been involved in the development of this, but I find the FreeBSD porter handbook confusing when detailing how to craft GH_TUPLE lines.

So I've used the commands inside the .sh by hand and a copy of the awk file to build GH_TUPLE for two ports. So I have found this invaluable to me.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
84 lines
4 lines

Diff 70642

View Options

Mk/Scripts/print-submodule-gh_tuple.sh

Loading...
View Options

Mk/bsd.sites.mk

Loading...