Switch to umount -A in rc.d/root and document it Our root serivce, which is primarly used to mount the root partition read-write, is executing `umount -a` at some point. It is somewhat confusing to the users to see it in a service, which is supposed to mount the partitions. Let's document the reasoning behind having umount in this service at all. Also, replace `umount -a` with `umount -A` as we do not intend to umount root anyway.
Details
Details
- Reviewers
allanjude - Group Reviewers
Contributor Reviews (src)
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30487 Build 28239: arc lint + arc unit
Event Timeline
Comment Actions
- Replace umount -a with umount -A
- Include some reasoning behind having umount there at all.
Comment Actions
I'm not sure the /dev/null bit is necessary here now since that was presumably originally to ignore the failed amount of root, in the days before the -A option was a thing. In fact, I think it's undesirable as any errors from umount -A are now something we need to see.
Comment Actions
It turns out this is not how umount -A works (https://reviews.freebsd.org/D25351).
Perhaps we should not switch to umount -A but just add a comment for the umount -a command.