Cadence GEM driver style clean-up.
ClosedPublic
Actions

Authored by skibo on Mar 30 2020, 6:30 PM.

Details

Reviewers: None
Commits: rS359571: Cadence GEM ethernet driver style clean-up, no functional changes.

Summary

I have significant changes to the GEM driver coming but the changes include
lots of style and white-space clean-up so I am submitting these separately
to perhaps make it easier to review the functional changes.

Test Plan

I have diffed the disassembly of if_cgem.o before and after these changes
and the only difference is a small change in string literal addresses
because I have tweaked a couple printf's.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

skibo created this revision.Mar 30 2020, 6:30 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 30 2020, 6:30 PM

Harbormaster completed remote builds in B30190: Diff 70012.Mar 30 2020, 6:30 PM

Ok, roast me!

sys/dev/cadence/if_cgem_hw.h
302 ↗	(On Diff #70012)	Another issue I noticed is that I am not consistent using upper or lower case letters in hex literals. Is there an accepted standard?