Differential D24226

Cadence GEM driver style clean-up.
ClosedPublic
Actions

Authored by skibo on Mar 30 2020, 6:30 PM.

Tags

None

Referenced Files

	F106177032: D24226.diff
	Thu, Dec 26, 4:10 PM

	Unknown Object (File)
	Tue, Dec 17, 3:39 AM

	Unknown Object (File)
	Tue, Dec 3, 12:27 PM

	Unknown Object (File)
	Nov 21 2024, 6:49 AM

	Unknown Object (File)
	Oct 25 2024, 4:09 AM

	Unknown Object (File)
	Oct 7 2024, 1:51 AM

	Unknown Object (File)
	Sep 13 2024, 12:24 AM

	Unknown Object (File)
	Sep 12 2024, 6:01 PM

View All 44 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers: None
Commits: rS359571: Cadence GEM ethernet driver style clean-up, no functional changes.

Summary

I have significant changes to the GEM driver coming but the changes include
lots of style and white-space clean-up so I am submitting these separately
to perhaps make it easier to review the functional changes.

Test Plan

I have diffed the disassembly of if_cgem.o before and after these changes
and the only difference is a small change in string literal addresses
because I have tweaked a couple printf's.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30190
Build 27982: arc lint + arc unit

Event Timeline

skibo created this revision.Mar 30 2020, 6:30 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 30 2020, 6:30 PM

Harbormaster completed remote builds in B30190: Diff 70012.Mar 30 2020, 6:30 PM

Ok, roast me!

sys/dev/cadence/if_cgem_hw.h
302	Another issue I noticed is that I am not consistent using upper or lower case letters in hex literals. Is there an accepted standard?

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 5:57 PM

Closed by commit rS359571: Cadence GEM ethernet driver style clean-up, no functional changes. (authored by • ian). · Explain Why

This revision was automatically updated to reflect the committed changes.

• ian added a commit: rS359571: Cadence GEM ethernet driver style clean-up, no functional changes..

Revision Contents
Changeset List

Path

Size

sys/

dev/

cadence/

484 lines

372 lines

Diff 70012

sys/dev/cadence/if_cgem.c

Loading...

sys/dev/cadence/if_cgem_hw.h

Loading...