Convert IP/IPv6 forwarding and ICMP processing to the new routing KPI.
ClosedPublic
Actions

Authored by melifaro on Mar 31 2020, 8:55 PM.

Details

Reviewers

ae
bz

Group Reviewers

network

Commits

rS359942: Convert IP/IPv6 forwarding, ICMP processing and IP PCB laddr selection to

Summary

Convert IP/IPv6 forwarding and ICMP processing to the new routing KPI.

This change depends on D24232.

Test Plan

divert:ipdivert_ip6_output_remote_success  ->  passed  [3.103s]
exthdr:exthdr  ->  passed  [102.480s]
forward6:fwd_ip6_gu_icmp_gw_gu_fast_success  ->  passed  [3.015s]
forward6:fwd_ip6_gu_icmp_gw_gu_slow_success  ->  passed  [2.488s]
forward6:fwd_ip6_gu_icmp_gw_ll_fast_success  ->  passed  [2.204s]
forward6:fwd_ip6_gu_icmp_gw_ll_slow_success  ->  passed  [2.759s]
forward6:fwd_ip6_gu_icmp_iface_fast_success  ->  passed  [2.640s]
forward6:fwd_ip6_gu_icmp_iface_slow_success  ->  passed  [2.890s]
mld:mldraw01  ->  passed  [4.067s]
output6:output6_raw_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.016s]
output6:output6_raw_success  ->  passed  [1.659s]
output6:output6_tcp_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.021s]
output6:output6_tcp_setup_success  ->  passed  [1.636s]
output6:output6_udp_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.021s]
output6:output6_udp_setup_success  ->  passed  [3.059s]
redirect:valid_redirect  ->  passed  [3.142s]
scapyi386:scapyi386  ->  passed  [4.244s]
frag6/frag6_01:frag6_01  ->  skipped: Sending IPv6 Jumbograms needs 1 kernel changes and BPF fixes  [0.019s]
frag6/frag6_02:frag6_02  ->  passed  [4.307s]
frag6/frag6_03:frag6_03  ->  passed  [4.471s]
frag6/frag6_04:frag6_04  ->  passed  [4.950s]
frag6/frag6_05:frag6_05_0  ->  passed  [79.899s]
frag6/frag6_05:frag6_05_1  ->  passed  [80.167s]
frag6/frag6_06:frag6_06_0  ->  passed  [4.968s]
frag6/frag6_07:frag6_07  ->  passed  [80.556s]
frag6/frag6_08:frag6_08  ->  passed  [80.705s]
frag6/frag6_09:frag6_09  ->  passed  [79.387s]
frag6/frag6_10:frag6_10  ->  passed  [79.515s]
frag6/frag6_11:frag6_11  ->  passed  [79.311s]
frag6/frag6_12:frag6_12  ->  passed  [79.306s]
frag6/frag6_13:frag6_13  ->  passed  [80.892s]
frag6/frag6_14:frag6_14  ->  passed  [79.529s]
frag6/frag6_15:frag6_15  ->  passed  [4.734s]
frag6/frag6_16:frag6_16  ->  passed  [5.903s]
frag6/frag6_17:frag6_17  ->  passed  [9.146s]
frag6/frag6_18:frag6_18  ->  passed  [9.573s]
frag6/frag6_19:frag6_19  ->  passed  [9.127s]
frag6/frag6_20:frag6_20  ->  passed  [79.477s]

divert:ipdivert_ip_input_local_success  ->  passed  [0.957s]
divert:ipdivert_ip_output_remote_success  ->  passed  [1.034s]
forward:fwd_ip_icmp_gw_fast_success  ->  passed  [1.094s]
forward:fwd_ip_icmp_gw_slow_success  ->  passed  [1.097s]
forward:fwd_ip_icmp_iface_fast_success  ->  passed  [1.056s]
forward:fwd_ip_icmp_iface_slow_success  ->  passed  [1.128s]
ip_reass_test:ip_reass__large_fragment  ->  passed  [0.015s]
ip_reass_test:ip_reass__multiple_last_fragments  ->  passed  [0.032s]
ip_reass_test:ip_reass__zero_length_fragment  ->  passed  [0.021s]
output:output_raw_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.045s]
output:output_raw_success  ->  passed  [0.082s]
output:output_tcp_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.026s]
output:output_tcp_setup_success  ->  passed  [0.146s]
output:output_udp_flowid_mpath_success  ->  skipped: This test requires ROUTE_MPATH enabled  [0.021s]
output:output_udp_setup_success  ->  passed  [1.224s]
redirect:valid_redirect  ->  passed  [1.076s]
so_reuseport_lb_test:basic_ipv4  ->  passed  [0.670s]
so_reuseport_lb_test:basic_ipv6  ->  passed  [0.801s]
socket_afinet:socket_afinet  ->  passed  [0.005s]
socket_afinet:socket_afinet_bind_ok  ->  passed  [0.004s]

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30220
Build 28006: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 31 2020, 8:55 PM

Herald added a subscriber: ae. · View Herald TranscriptMar 31 2020, 8:55 PM

Harbormaster completed remote builds in B30220: Diff 70075.Mar 31 2020, 8:55 PM

melifaro edited the summary of this revision. (Show Details)Mar 31 2020, 9:10 PM

melifaro edited the test plan for this revision. (Show Details)

melifaro added reviewers: network, ae, bz.

melifaro added a parent revision: D24232: Stage 1: Introduce nexhop objects and new routing kpi.

melifaro mentioned this in D24232: Stage 1: Introduce nexhop objects and new routing kpi.Apr 8 2020, 10:24 PM

melifaro mentioned this in D5010: Convert IPv6 forwarding to the new routing KPI..Apr 10 2020, 5:40 PM

Update diff to account for the committed changes.

Harbormaster completed remote builds in B30448: Diff 70479.Apr 12 2020, 10:33 PM

ae added inline comments.Apr 13 2020, 9:57 AM

sys/netinet/in_pcb.c
1187	It looks like we can use `sin' that is already initialized.
sys/netinet/ip_icmp.c
972	In another review you told that proper sin_family initialization is not required. Will sa_equal work correctly in this case? Is this structure properly initialized? :)
sys/netinet6/ip6_fastfwd.c
284	Does sin6_addr here have embedded scope zone id? LLE lookup did need address with embedded scope zone id. Did you make test when GW address is LLA?

melifaro added inline comments.Apr 13 2020, 11:24 AM

sys/netinet/in_pcb.c
1187	Good catch! Will update the review shortly.
sys/netinet/ip_icmp.c
972	sin_family initialisation is not required for the lookup. Gateway sockaddr in the nexthop is aways filled in properly. As here `src` should also be proper sockaddr, I guess it should continue working as is.

melifaro added inline comments.Apr 13 2020, 5:37 PM

sys/netinet6/ip6_fastfwd.c
284	Yes, the gateway always have scopeid embedded - exactly for the purpose of passing it to LLE. At some point in time we should just convert LLE layer to accept non-embedded addresses and mark l3+l2 lookups as embed-free