Differential D24229

nlist: retire long-obsolete aout support
ClosedPublic
Actions

Authored by emaste on Mar 30 2020, 6:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 1, 9:26 AM

	Unknown Object (File)
	Sun, Jun 30, 9:18 AM

	Unknown Object (File)
	Sat, Jun 29, 8:18 PM

	Unknown Object (File)
	Sat, Jun 29, 4:19 AM

	Unknown Object (File)
	Fri, Jun 28, 8:25 PM

	Unknown Object (File)
	Wed, Jun 26, 2:44 PM

	Unknown Object (File)
	Sat, Jun 22, 11:05 AM

	Unknown Object (File)
	Fri, Jun 21, 1:36 PM

View All 29 Files

Subscribers

Details

Reviewers

brooks
kib

Group Reviewers

Commits

rS359460: nlist: retire long-obsolete aout support

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Mar 30 2020, 6:45 PM

kib accepted this revision.Mar 30 2020, 7:36 PM

This revision is now accepted and ready to land.Mar 30 2020, 7:36 PM

brooks accepted this revision.Mar 30 2020, 7:57 PM

brooks added inline comments.

lib/libc/gen/nlist.c
54	I'd be tempted to do an additional commit nuking _NLIST_DO_ELF as almost certainly pointless abstraction.

emaste added inline comments.Mar 30 2020, 8:06 PM

lib/libc/gen/nlist.c
54	Yep, I wanted to keep this separate.

Closed by commit rS359460: nlist: retire long-obsolete aout support (authored by emaste). · Explain WhyMar 30 2020, 8:15 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS359460: nlist: retire long-obsolete aout support.

Herald added a reviewer: manpages. · View Herald TranscriptMar 30 2020, 8:15 PM

Herald added a subscriber: imp. · View Herald Transcript

People (maybe just bde) were still builing aout kernels through the 5.x time frame, even though we'd cut over to ELF in 3.2... So yea, this is fine.
Do you need _NLIST_DO_ELF anymore? can't you unifdef things?

In D24229#533104, @imp wrote:

Do you need _NLIST_DO_ELF anymore? can't you unifdef things?

@brooks also suggested doing away with this; I think that's a good idea and will do in a followup commit.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

1 line

1 line

102 lines

Diff 70016

lib/libc/gen/Symbol.map

Loading...

lib/libc/gen/nlist.3

Loading...

lib/libc/gen/nlist.c

Loading...