kern_dup(): Call filecaps_free_prep() in a write section.
ClosedPublic
Actions

Authored by markj on Mar 18 2020, 10:18 PM.

Details

Reviewers

kib
mjg

Commits

rS359133: kern_dup(): Call filecaps_free_prep() in a write section.

Summary

filecaps_free_prep() bzeros the capabilities structure and we need to be
careful to synchronize with unlocked readers, which expect a consistent
rights structure.

I'm not really sure it's even worth keeping filecaps_free_prep(), since it's
doing some unnecessary work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 18 2020, 10:18 PM

Harbormaster completed remote builds in B30003: Diff 69668.Mar 18 2020, 10:18 PM

markj edited the summary of this revision. (Show Details)Mar 18 2020, 10:22 PM

markj added reviewers: kib, mjg.

kib accepted this revision.Mar 18 2020, 11:50 PM

This revision is now accepted and ready to land.Mar 18 2020, 11:50 PM

The original capsicum code introduced a lot of bzeroing which can probably be eliminated.

Closed by commit rS359133: kern_dup(): Call filecaps_free_prep() in a write section. (authored by markj). · Explain WhyMar 19 2020, 3:40 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS359133: kern_dup(): Call filecaps_free_prep() in a write section..

Herald added a subscriber: imp. · View Herald TranscriptMar 19 2020, 3:40 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_descrip.c

2 lines

Diff 69686

View Options

head/sys/kern/kern_descrip.c

kern_dup(): Call filecaps_free_prep() in a write section.ClosedPublicActions