Page MenuHomeFreeBSD

kern_dup(): Call filecaps_free_prep() in a write section.
ClosedPublic

Authored by markj on Mar 18 2020, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2024, 3:47 PM
Unknown Object (File)
Mar 4 2024, 3:47 PM
Unknown Object (File)
Mar 4 2024, 3:47 PM
Unknown Object (File)
Mar 3 2024, 10:08 PM
Unknown Object (File)
Dec 23 2023, 10:47 AM
Unknown Object (File)
Nov 28 2023, 8:48 PM
Unknown Object (File)
Nov 28 2023, 8:48 PM
Unknown Object (File)
Nov 28 2023, 8:48 PM
Subscribers

Details

Summary

filecaps_free_prep() bzeros the capabilities structure and we need to be
careful to synchronize with unlocked readers, which expect a consistent
rights structure.

I'm not really sure it's even worth keeping filecaps_free_prep(), since it's
doing some unnecessary work.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30003
Build 27816: arc lint + arc unit

Event Timeline

markj added reviewers: kib, mjg.
This revision is now accepted and ready to land.Mar 18 2020, 11:50 PM
mjg accepted this revision.EditedMar 19 2020, 3:07 AM

The original capsicum code introduced a lot of bzeroing which can probably be eliminated.