Disallows SCTP socket for sendfile()
ClosedPublic
Actions

Authored by tuexen on Mar 13 2020, 11:19 AM.

Details

Reviewers

markj
glebius

Group Reviewers

manpages

Commits

rS358965: sendfile() does currently not support SCTP sockets.

Summary

SCTP sockets were or were not supported by sendfile() in the past. However, at least since the rewrite of sendfile(), SCTP sockets can't be used in combination with sendfile(). So fail such calls indicating EINVAL.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Mar 13 2020, 11:19 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 13 2020, 11:19 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B29924: Diff 69473.Mar 13 2020, 11:19 AM

markj added inline comments.Mar 13 2020, 4:48 PM

sys/kern/kern_sendfile.c
581 ↗	(On Diff #69473)	What exactly is the problem?

tuexen added inline comments.Mar 13 2020, 5:09 PM

sys/kern/kern_sendfile.c
581 ↗	(On Diff #69473)	Haven't looked at it, never used sendfile in combination with SCTP. If I remember it correctly, when @glebius rewrote the code, we had to do some changes related to `sb_acc` and `sb_ccc`. Right now we use #define sb_cc sb_acc At that point there was a discussion (if I remember it correctly) between rrs@ and glebius@ whether sendfile worked with SCTP before the rewrite or not. However, sendfile support doesn't work with SCTP sockets now as you can see in your syzkaller instance. If you look at traces were SCTP is involved, you will find a set of crashes where calling sendfile() on an SCTP is involved. I want to mitigate these problems.