Remove dead code from the powerpc uma_small_alloc().
ClosedPublic
Actions

Authored by markj on Mar 6 2020, 8:23 PM.

Tags

None

Referenced Files

	F170790284: D23991.id69277.diff
	Sun, Sep 6, 3:45 PM

	Unknown Object (File)
	Thu, Sep 3, 5:36 PM

	Unknown Object (File)
	Thu, Sep 3, 5:10 PM

	Unknown Object (File)
	Thu, Sep 3, 3:26 PM

	Unknown Object (File)
	Tue, Sep 1, 9:51 PM

	Unknown Object (File)
	Tue, Sep 1, 4:17 PM

	Unknown Object (File)
	Tue, Sep 1, 3:34 PM

	Unknown Object (File)
	Sun, Aug 30, 8:25 PM

View All Files

Subscribers

imp

jhibbits

Details

Reviewers

jhibbits
bdragon
luporl

Commits

rS358718: Remove dead code from the powerpc uma_small_alloc().

Summary

32-bit Book-E doesn't set UMA_MD_SMALL_ALLOC, and 32-bit OEA platforms
have a 32-bit vm_paddr_t. Moreover, this code was wrong in that it
leaked the page if the check failed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29833
Build 27659: arc lint + arc unit

Event Timeline

markj created this revision.Mar 6 2020, 8:23 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptMar 6 2020, 8:23 PM

Harbormaster completed remote builds in B29833: Diff 69277.Mar 6 2020, 8:23 PM

markj added reviewers: jhibbits, bdragon, luporl.Mar 6 2020, 8:23 PM

Yep, been meaning to clean this up since not too long after I initially committed it anyway...

This revision is now accepted and ready to land.Mar 6 2020, 8:33 PM

Closed by commit rS358718: Remove dead code from the powerpc uma_small_alloc(). (authored by markj). · Explain WhyMar 6 2020, 8:44 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS358718: Remove dead code from the powerpc uma_small_alloc()..

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2020, 8:44 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

uma_machdep.c

5 lines

Diff 69277

View Options

sys/powerpc/powerpc/uma_machdep.c

Remove dead code from the powerpc uma_small_alloc().ClosedPublicActions