Page MenuHomeFreeBSD
Differential D23977

Add COUNTER_U64_SYSINIT().
ClosedPublic
Actions

Authored by markj on Mar 5 2020, 7:11 PM.
Tags
None
Referenced Files
F135249998: D23977.id.diff
Fri, Nov 7, 11:42 PM
Unknown Object (File)
Fri, Oct 24, 9:38 PM
Unknown Object (File)
Thu, Oct 23, 11:18 AM
Unknown Object (File)
Thu, Oct 23, 2:40 AM
Unknown Object (File)
Thu, Oct 23, 2:40 AM
Unknown Object (File)
Thu, Oct 23, 2:40 AM
Unknown Object (File)
Wed, Oct 22, 6:48 PM
Unknown Object (File)
Oct 5 2025, 1:14 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
glebius
Group Reviewers
manpages
Commits
rS358715: Add COUNTER_U64_SYSINIT() and COUNTER_U64_DEFINE_EARLY().
Summary

This is the same idea as MTX_SYSINIT and friends: register a global
counter for initialization when the counter(9) subsystem is ready,
instead of having to write a custom sysinit function.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29827
Build 27653: arc lint + arc unit

Event Timeline

markj created this revision.Mar 5 2020, 7:11 PM
Harbormaster completed remote builds in B29814: Diff 69234.Mar 5 2020, 7:11 PM
markj added reviewers: kib, glebius.Mar 5 2020, 7:12 PM
kib accepted this revision.Mar 5 2020, 9:25 PM
kib added inline comments.
sys/sys/counter.h
78

I am somewhat curious about selection of the si_sub there.

This revision is now accepted and ready to land.Mar 5 2020, 9:25 PM
markj added inline comments.Mar 5 2020, 9:31 PM
sys/sys/counter.h
78

It is just inherited from the existing sysinits which initialize counters. It could be moved earlier, I think the only prerequisite is that the pcpu zones are initialized.

markj updated this revision to Diff 69267.Mar 6 2020, 3:53 PM
  • Add COUNTER_U64_DEFINE_EARLY.
  • Add SI_SUB_COUNTER to make initialization ordering more explicit.
This revision now requires review to proceed.Mar 6 2020, 3:53 PM
Harbormaster completed remote builds in B29827: Diff 69267.Mar 6 2020, 3:53 PM
kib accepted this revision.Mar 6 2020, 4:22 PM
This revision is now accepted and ready to land.Mar 6 2020, 4:22 PM
Closed by commit rS358715: Add COUNTER_U64_SYSINIT() and COUNTER_U64_DEFINE_EARLY(). (authored by markj). · Explain WhyMar 6 2020, 7:09 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS358715: Add COUNTER_U64_SYSINIT() and COUNTER_U64_DEFINE_EARLY()..
Herald added a reviewer: manpages. · View Herald TranscriptMar 6 2020, 7:09 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
sys/
kern/
18 lines
2 lines
sys/
13 lines
3 lines

Diff 69267

View Options

sys/kern/subr_counter.c

Loading...
View Options

sys/kern/subr_pcpu.c

Loading...
View Options

sys/sys/counter.h

Loading...
View Options

sys/sys/kernel.h

Loading...