Page MenuHomeFreeBSD

Add EVDEV_SUPPORT to acpi_button and acpi_lid
ClosedPublic

Authored by • hselasky on Feb 27 2020, 10:06 PM.
Tags
None
Referenced Files
F173986562: D23863.id69059.diff
Tue, Sep 29, 7:25 PM
F173986420: D23863.id68919.diff
Tue, Sep 29, 7:23 PM
F173986280: D23863.id68918.diff
Tue, Sep 29, 7:22 PM
F173968860: D23863.diff
Tue, Sep 29, 5:11 PM
Unknown Object (File)
Fri, Sep 25, 10:01 PM
Unknown Object (File)
Mon, Sep 21, 6:22 PM
Unknown Object (File)
Fri, Sep 18, 1:04 PM
Unknown Object (File)
Fri, Sep 18, 12:32 AM
Subscribers

Details

Summary

On Linux, these ACPI devices are exposed as evdev. This is useful for a bunch of things — libinput disables touchpads when the lid is closed, various DEs can show power-off dialogs when the power is pressed, etc. (While the latter should be doable with devd, a cross-platform solution is nicer.)

Test Plan

Tested libinput's touchpad disablement on my Pixelbook.

Couldn't test acpi_button: the Pixelbook power button is part of the *keyboard*, while on my desktop the button is not getting to that code for some reason.. (no devd event either)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 29719

Event Timeline

sys/dev/acpica/acpi_lid.c
119

Can you test this w/ suspend and resume.

• hselasky updated this revision to Diff 69058.
• hselasky edited reviewers, added: val_packett.cool; removed: • hselasky.

Mostly style nits and an init order fix in case of error.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2020, 9:45 AM
This revision was automatically updated to reflect the committed changes.