Page MenuHomeFreeBSD
Differential D23819

x11/libwacom: convert to USES=meson
ClosedPublic
Actions

Authored by jbeich on Feb 24 2020, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 11:43 PM
Unknown Object (File)
Thu, Oct 17, 11:26 AM
Unknown Object (File)
Oct 7 2024, 1:57 AM
Unknown Object (File)
Oct 6 2024, 2:01 AM
Unknown Object (File)
Oct 5 2024, 10:52 PM
Unknown Object (File)
Oct 5 2024, 9:47 PM
Unknown Object (File)
Oct 5 2024, 8:50 PM
Unknown Object (File)
Oct 5 2024, 8:38 PM
View All Files
Subscribers
manu
zeising

Details

Reviewers
val_packett.cool
manu
zeising
Group Reviewers
x11
Commits
rP527163: x11/libwacom: convert to USES=meson
Test Plan

Builds fine on:

  • 11.3 aarch64
  • 11.3 amd64
  • 11.3 armv6
  • 11.3 i386
  • 12.0 amd64
  • 12.0 i386
  • 12.1 aarch64
  • 12.1 amd64
  • 12.1 armv6
  • 12.1 armv7
  • 12.1 i386
  • 13.0 amd64
  • 13.0 i386
  • Base GCC 4.2.1 (mimics powerpc*, mips*, riscv64)
  • x11/libinput (the only consumer)

Works fine on:

  • Bamboo Pen&Touch (CTH-470)
  • x11-drivers/xf86-input-libinput
  • x11-wm/sway

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29578
Build 27439: arc lint + arc unit

Event Timeline

jbeich created this revision.Feb 24 2020, 6:46 PM
Harbormaster completed remote builds in B29577: Diff 68765.Feb 24 2020, 6:46 PM
jbeich updated this revision to Diff 68766.Feb 24 2020, 6:48 PM
  • Fix upstream URL
Harbormaster completed remote builds in B29578: Diff 68766.Feb 24 2020, 6:48 PM
jbeich edited the test plan for this revision. (Show Details)Feb 24 2020, 6:51 PM
jbeich added a parent revision: D23818: x11/libwacom: update to 1.2.
jbeich updated this revision to Diff 68767.Feb 24 2020, 6:52 PM
  • Sort USES per ports-mgmt/portfmt
Harbormaster completed remote builds in B29579: Diff 68767.Feb 24 2020, 6:52 PM
jbeich updated this revision to Diff 68768.Feb 24 2020, 6:55 PM
  • Drop USES=pkgconfig as it's unused like USES=tar:bzip2
Harbormaster completed remote builds in B29580: Diff 68768.Feb 24 2020, 6:55 PM
jbeich updated this revision to Diff 68769.Feb 24 2020, 6:58 PM
  • Revert last change (add back USES=pkgconfig) due to botched testing
Harbormaster completed remote builds in B29581: Diff 68769.Feb 24 2020, 6:58 PM
jbeich updated this revision to Diff 68794.Feb 25 2020, 10:46 AM
  • Switch Meson fix to the version merged upstream
Harbormaster completed remote builds in B29593: Diff 68794.Feb 25 2020, 10:46 AM
manu accepted this revision as: manu.Feb 25 2020, 10:59 AM
manu added a subscriber: manu.

Not tested but looks good.
Commit messge should also say that we install those new layouts files (and why).

This revision is now accepted and ready to land.Feb 25 2020, 10:59 AM
jbeich added a comment.Feb 25 2020, 12:19 PM
In D23819#523735, @manu wrote:

Not tested but looks good.
Commit messge should also say that we install those new layouts files (and why).

"Why" is an existing bug in autotools-based build i.e., post-patch missed data/layouts/Makefile.am.

jbeich updated this revision to Diff 68798.Feb 25 2020, 12:25 PM
  • Rebase
This revision now requires review to proceed.Feb 25 2020, 12:25 PM
Harbormaster completed remote builds in B29597: Diff 68798.Feb 25 2020, 12:25 PM
manu accepted this revision as: manu.Feb 25 2020, 12:31 PM

Thanks for the explanation.

This revision is now accepted and ready to land.Feb 25 2020, 12:31 PM
zeising accepted this revision.Feb 26 2020, 9:00 AM
zeising added a subscriber: zeising.

Have you checked that downstream consumers are ok with the static library disappearing?
Once that's done, this is OK.

jbeich added a comment.Feb 26 2020, 9:30 AM
In D23819#524072, @zeising wrote:

Have you checked that downstream consumers are ok with the static library disappearing?

"x11/libinput (the only consumer)" has been in Test Plan before you've asked.

Once that's done, this is OK.

I've also tested whether libinput works properly without rebuild.

Closed by commit rP527163: x11/libwacom: convert to USES=meson (authored by jbeich). · Explain WhyFeb 26 2020, 11:47 AM
This revision was automatically updated to reflect the committed changes.
jbeich added a commit: rP527163: x11/libwacom: convert to USES=meson.

Revision Contents
Changeset List

PathSize
x11/
libwacom/
12 lines
4 lines
75 lines

Diff 68766

View Options

x11/libwacom/Makefile

Loading...
View Options

x11/libwacom/distinfo

Loading...
View Options

x11/libwacom/pkg-plist

Loading...