Page MenuHomeFreeBSD

x11/libwacom: convert to USES=meson
ClosedPublic

Authored by jbeich on Feb 24 2020, 6:46 PM.

Details

Test Plan

Builds fine on:

  • 11.3 aarch64
  • 11.3 amd64
  • 11.3 armv6
  • 11.3 i386
  • 12.0 amd64
  • 12.0 i386
  • 12.1 aarch64
  • 12.1 amd64
  • 12.1 armv6
  • 12.1 armv7
  • 12.1 i386
  • 13.0 amd64
  • 13.0 i386
  • Base GCC 4.2.1 (mimics powerpc*, mips*, riscv64)
  • x11/libinput (the only consumer)

Works fine on:

  • Bamboo Pen&Touch (CTH-470)
  • x11-drivers/xf86-input-libinput
  • x11-wm/sway

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • Sort USES per ports-mgmt/portfmt
  • Drop USES=pkgconfig as it's unused like USES=tar:bzip2
  • Revert last change (add back USES=pkgconfig) due to botched testing
  • Switch Meson fix to the version merged upstream
manu added a subscriber: manu.

Not tested but looks good.
Commit messge should also say that we install those new layouts files (and why).

This revision is now accepted and ready to land.Feb 25 2020, 10:59 AM
In D23819#523735, @manu wrote:

Not tested but looks good.
Commit messge should also say that we install those new layouts files (and why).

"Why" is an existing bug in autotools-based build i.e., post-patch missed data/layouts/Makefile.am.

This revision now requires review to proceed.Feb 25 2020, 12:25 PM

Thanks for the explanation.

This revision is now accepted and ready to land.Feb 25 2020, 12:31 PM
zeising added a subscriber: zeising.

Have you checked that downstream consumers are ok with the static library disappearing?
Once that's done, this is OK.

Have you checked that downstream consumers are ok with the static library disappearing?

"x11/libinput (the only consumer)" has been in Test Plan before you've asked.

Once that's done, this is OK.

I've also tested whether libinput works properly without rebuild.

This revision was automatically updated to reflect the committed changes.