Page MenuHomeFreeBSD
Differential D23798

sys/kern: quiet -Wwrite-strings
ClosedPublic
Actions

Authored by rlibby on Feb 22 2020, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 20, 5:24 PM
Unknown Object (File)
Wed, Aug 19, 5:06 PM
Unknown Object (File)
Tue, Aug 18, 8:31 PM
Unknown Object (File)
Tue, Aug 18, 8:14 PM
Unknown Object (File)
Tue, Aug 18, 2:45 PM
Unknown Object (File)
Mon, Aug 17, 7:42 PM
Unknown Object (File)
Sun, Aug 16, 9:02 PM
Unknown Object (File)
Sat, Aug 15, 7:46 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rS358258: sys/kern: quiet -Wwrite-strings
Summary

Quiet a variety of Wwrite-strings warnings in sys/kern at low-impact
sites. This patch avoids addressing certain others which would need to
plumb const through structure definitions.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29537
Build 27402: arc lint + arc unit

Event Timeline

rlibby created this revision.Feb 22 2020, 9:49 PM
Harbormaster completed remote builds in B29537: Diff 68687.Feb 22 2020, 9:49 PM
markj accepted this revision.Feb 22 2020, 10:11 PM
This revision is now accepted and ready to land.Feb 22 2020, 10:11 PM
kib accepted this revision.Feb 22 2020, 10:25 PM
kib added inline comments.
sys/kern/kern_cons.c
101

Make this static const char [] ? What is the point of the additional indirection ?

sys/kern/kern_linker.c
1768

Again const char * const ?

Closed by commit rS358258: sys/kern: quiet -Wwrite-strings (authored by rlibby). · Explain WhyFeb 23 2020, 3:32 AM
This revision was automatically updated to reflect the committed changes.
rlibby marked 2 inline comments as done.
rlibby added a commit: rS358258: sys/kern: quiet -Wwrite-strings.
Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2020, 3:32 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines
8 lines
2 lines
2 lines
2 lines
sys/
2 lines
2 lines
2 lines
2 lines

Diff 68687

View Options

sys/kern/kern_cons.c

Loading...
View Options

sys/kern/kern_linker.c

Loading...
View Options

sys/kern/kern_shutdown.c

Loading...
View Options

sys/kern/kern_sig.c

Loading...
View Options

sys/kern/link_elf.c

Loading...
View Options

sys/sys/bufobj.h

Loading...
View Options

sys/sys/conf.h

Loading...
View Options

sys/sys/cons.h

Loading...
View Options

sys/sys/signalvar.h

Loading...