kern_dump.c: move kernel dump code out of kern_shutdown.c
AbandonedPublic
Actions

Authored by markj on Jul 12 2015, 2:18 AM.

Details

Reviewers

Summary

Consolidate kernel dump code in kern_dump.c. Support for compressed
dumps will require extending the dump_write() interface, and
kern_shutdown.c seems like the wrong place to add this code.

Definitions for dumper_t and struct dumperinfo remain in conf.h since
they're required by drivers that implement a dumper routine, and drivers
aren't typically interested in the implementation details of kernel
dumps (which is what kerneldump.h exposes).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

markj updated this revision to Diff 6864.Jul 12 2015, 2:18 AM

markj retitled this revision from to kern_dump.c: move kernel dump code out of kern_shutdown.c.

markj edited the test plan for this revision. (Show Details)

markj added a reviewer: rstone.

markj updated this object.

markj added a subscriber: cem.

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2015, 2:18 AM

cem added inline comments.Jul 12 2015, 4:11 AM

sys/kern/kern_dump.c
81–82	How much do we care about keeping the sysctl kern.shutdown.dumpdevname?
sys/kern/kern_shutdown.c
99–101	Why move this?

I'm on the fence about this change - defining a kern.shutdown sysctl in kern_dump.c is a bit ugly, and kern_dump.c now contains two mostly-distinct groups of code: dumpsys stuff, and I/O stuff. So I'm not sure this is an improvement over keeping stuff in kern_shutdown.c. I would like to keep kernel dump-related stuff out of conf.h and in kerneldump.h, though.

If you have strong feelings either way, please comment. :)