Make get_proccess_cputime and get_thread_cputime public api
ClosedPublic
Actions

Authored by dchagin on Jan 23 2020, 7:13 PM.

Details

Reviewers

kib
emaste

Group Reviewers

Linux Emulation

Commits

rS357492: For code reuse in Linuxulator rename get_proccess_cputime()

Summary

For code reuse in Linuxulator rename get_proccess_cputime() and get_thread_cputime() and add prototypes for it to <sys/syscallsubr.h>.
Fix whitespace nit while here.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29134
Build 27070: arc lint + arc unit

Event Timeline

dchagin created this revision.Jan 23 2020, 7:13 PM

Harbormaster completed remote builds in B28884: Diff 67224.Jan 23 2020, 7:13 PM

dchagin added reviewers: kib, emaste, Linux Emulation.Jan 23 2020, 7:23 PM

dchagin mentioned this in D22075: PR240990: linux: handle the CLOCK_{PROCESS,THREAD}_CPUTIME_ID specified directly.Jan 23 2020, 7:39 PM

kib mentioned this in D23341: Fix Linuxulator clock_gettime() and clock_getres() for cpu clocks.Jan 23 2020, 10:02 PM

It seems that both functions use process lock as a way to ensure that the process is not exiting under it. This should be asserted since functions become public interface.

Add process lock assert

Harbormaster completed remote builds in B29134: Diff 67711.Feb 3 2020, 4:30 PM

kib accepted this revision.Feb 3 2020, 6:12 PM

This revision is now accepted and ready to land.Feb 3 2020, 6:12 PM

Closed by commit rS357492: For code reuse in Linuxulator rename get_proccess_cputime() (authored by dchagin). · Explain WhyFeb 4 2020, 5:26 AM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rS357492: For code reuse in Linuxulator rename get_proccess_cputime().

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2020, 5:26 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_time.c

24 lines

sys/

syscallsubr.h

2 lines

Diff 67711

View Options

sys/kern/kern_time.c

	SHA256 (rpm/i686/centos/6.6/atk-1.30.0-1.el6.i686.rpm) = 1fb6cdc8bdeaab448dc07d6c326fe402e3170e7b4e9fff84de45c6fc9aeee216			SHA256 (rpm/i686/centos/6.7/atk-1.30.0-1.el6.i686.rpm) = 1fb6cdc8bdeaab448dc07d6c326fe402e3170e7b4e9fff84de45c6fc9aeee216
	SIZE (rpm/i686/centos/6.6/atk-1.30.0-1.el6.i686.rpm) = 198868			SIZE (rpm/i686/centos/6.7/atk-1.30.0-1.el6.i686.rpm) = 198868
	SHA256 (rpm/i686/centos/6.6/atk-1.30.0-1.el6.src.rpm) = fc87523ecb6cb944f9452a9da4385c73346acc3714ea494d3110245c4fbce12a			SHA256 (rpm/i686/centos/6.7/atk-1.30.0-1.el6.src.rpm) = fc87523ecb6cb944f9452a9da4385c73346acc3714ea494d3110245c4fbce12a
	SIZE (rpm/i686/centos/6.6/atk-1.30.0-1.el6.src.rpm) = 758480			SIZE (rpm/i686/centos/6.7/atk-1.30.0-1.el6.src.rpm) = 758480