Differential D23341

Fix Linuxulator clock_gettime() and clock_getres() for cpu clocks
ClosedPublic
Actions

Authored by dchagin on Jan 23 2020, 7:37 PM.

Details

Reviewers

kib

Group Reviewers

Linux Emulation

Commits

rS357493: Fix clock_gettime() and clock_getres() for cpu clocks:

Summary

handle the CLOCK_{PROCESS,THREAD}_CPUTIME_ID specified directly;
fix thread/proccess id calculation as in the Linuxulator we should convert the user supplied thread/proccess id by linux_tdfind();
fix CPUCLOCK_SCHED case by using kern_{process,thread}_cputime() directly as native get_cputime() used by kern_clock_gettime() uses native tdfind()/pfind() to find proccess/thread.

PR: 240990

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Jan 23 2020, 7:37 PM

Harbormaster completed remote builds in B28885: Diff 67225.Jan 23 2020, 7:37 PM

dchagin added reviewers: Linux Emulation, kib.Jan 23 2020, 7:38 PM

dchagin mentioned this in D22075: PR240990: linux: handle the CLOCK_{PROCESS,THREAD}_CPUTIME_ID specified directly.

Why do you need D23340 ? Why the current method is not sufficient ?

In D23341#511764, @kib wrote:

Why do you need D23340 ? Why the current method is not sufficient ?

hi, in case when the Linux clock id obtained via pthread_getcpuclockid() call we should use linux_tdfind() to convert thread id of clock id to native struct thread.

kib accepted this revision.Feb 1 2020, 10:20 PM

This revision is now accepted and ready to land.Feb 1 2020, 10:20 PM

Closed by commit rS357493: Fix clock_gettime() and clock_getres() for cpu clocks: (authored by dchagin). · Explain WhyFeb 4 2020, 5:27 AM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rS357493: Fix clock_gettime() and clock_getres() for cpu clocks:.

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2020, 5:27 AM