Remove unused fields from struct pcb.
ClosedPublic
Actions

Authored by jhb on Jan 28 2020, 11:31 AM.

Details

Reviewers

br
mhorne
jrtc27

Commits

rS357305: Remove unused fields from struct pcb.

Summary

cpu_switch/throw() and savectx() do not save or restore any values
in these fields which mostly held non-callee-save registers.

makectx() copied these fields from kdb_frame, but they weren't used
except for PC_REGS using pcb_sepc. Change PC_REGS to use
kdb_frame->tf_sepc directly instead.

Test Plan

booted qemu, stack traces work for both curthread and other threads in ddb

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 28 2020, 11:31 AM

Harbormaster completed remote builds in B28972: Diff 67397.Jan 28 2020, 11:31 AM

Looks good

This revision is now accepted and ready to land.Jan 28 2020, 11:53 AM

Closed by commit rS357305: Remove unused fields from struct pcb. (authored by jhb). · Explain WhyJan 30 2020, 7:15 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357305: Remove unused fields from struct pcb..

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2020, 7:15 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

include/

db_machdep.h

2 lines

pcb.h

3 lines

riscv/

genassym.c

2 lines

machdep.c

3 lines

Diff 67525

View Options

head/sys/riscv/include/db_machdep.h

View Options

head/sys/riscv/include/pcb.h

View Options

head/sys/riscv/riscv/genassym.c

View Options

head/sys/riscv/riscv/machdep.c

Remove unused fields from struct pcb.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 67525

head/sys/riscv/include/db_machdep.h

head/sys/riscv/include/pcb.h

head/sys/riscv/riscv/genassym.c

head/sys/riscv/riscv/machdep.c

Remove unused fields from struct pcb.
ClosedPublic
Actions

Revision Contents
Changeset List