Export the current da flags as bitfield
ClosedPublic
Actions

Authored by imp on Jan 29 2020, 8:13 PM.

Details

Reviewers

ken
scottl
mav

Commits

rS357849: Convert rotating and unmapped_io to a DA flag
rS357848: Export the current da flags as bitfield

Summary

Export the current flags. They can be useful to other programs wanting to do
special thigns for removable or similar devices.

Convert rotating to a DA flag

Rotating is really a da flag. Convert it to a flag so it will be reported with
the other flags for the device. Deprecate the .rotating sysctl in FreeBSD 14.

Make unmapped I/O a flag as well

Although it's really a flag on the underlying disk, add it to the softc flags as
well since we report the unmapped status as a sysctl. This will let us retire
that as well in the future.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29026
Build 26994: arc lint + arc unit

Event Timeline

imp created this revision.Jan 29 2020, 8:13 PM

Harbormaster completed remote builds in B29026: Diff 67473.Jan 29 2020, 8:13 PM

imp added reviewers: ken, scottl, mav.Jan 29 2020, 8:14 PM

My recommendation is to change the rotating and unmapped sysctls to be SYSCTL_PROC, and have them read the flag. That way you can retire the fields out of the softc now.

This revision now requires changes to proceed.Jan 30 2020, 1:54 AM

Also, this should be MFC'd to 12 and even 11. With that, you can remove in 13 instead of waiting for 14

Update, per scottl

Add a sysctl flag to int function. Maybe this should be in kern_sysctl.c

Harbormaster completed remote builds in B29335: Diff 68232.Feb 13 2020, 1:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 1:23 AM

Closed by commit rS357848: Export the current da flags as bitfield (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS357848: Export the current da flags as bitfield.

imp added a commit: rS357849: Convert rotating and unmapped_io to a DA flag.