Remove unused fields from struct pcb.
ClosedPublic
Actions

Authored by jhb on Jan 28 2020, 11:31 AM.

Details

Reviewers

br
mhorne
jrtc27

Commits

rS357305: Remove unused fields from struct pcb.

Summary

cpu_switch/throw() and savectx() do not save or restore any values
in these fields which mostly held non-callee-save registers.

makectx() copied these fields from kdb_frame, but they weren't used
except for PC_REGS using pcb_sepc. Change PC_REGS to use
kdb_frame->tf_sepc directly instead.

Test Plan

booted qemu, stack traces work for both curthread and other threads in ddb

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28972
Build 26951: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 28 2020, 11:31 AM

Harbormaster completed remote builds in B28972: Diff 67397.Jan 28 2020, 11:31 AM

Looks good

This revision is now accepted and ready to land.Jan 28 2020, 11:53 AM

Closed by commit rS357305: Remove unused fields from struct pcb. (authored by jhb). · Explain WhyJan 30 2020, 7:15 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357305: Remove unused fields from struct pcb..

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2020, 7:15 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

include/

db_machdep.h

2 lines

pcb.h

3 lines

riscv/

genassym.c

2 lines

machdep.c

3 lines

Diff 67397

View Options

sys/riscv/include/db_machdep.h

View Options

sys/riscv/include/pcb.h

View Options

sys/riscv/riscv/genassym.c

View Options

Remove unused fields from struct pcb.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 67397

sys/riscv/include/db_machdep.h

sys/riscv/include/pcb.h

sys/riscv/riscv/genassym.c

sys/riscv/riscv/machdep.c

Remove unused fields from struct pcb.
ClosedPublic
Actions

Revision Contents
Changeset List