Page MenuHomeFreeBSD
Differential D23363

Fix some misleading indentation warnings reported by recent clang.
ClosedPublic
Actions

Authored by jhb on Jan 25 2020, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 12:43 PM
Unknown Object (File)
Wed, Aug 12, 4:31 AM
Unknown Object (File)
Tue, Aug 11, 12:28 PM
Unknown Object (File)
Mon, Aug 10, 8:19 PM
Unknown Object (File)
Mon, Aug 10, 8:18 PM
Unknown Object (File)
Mon, Aug 10, 8:18 PM
Unknown Object (File)
Mon, Aug 10, 4:59 PM
Unknown Object (File)
Sun, Aug 9, 8:01 PM
View All Files
Subscribers
brooks
dim
imp

Details

Reviewers
kib
Commits
rS360305: MFC r357146 (partial, by jhb):
rS357146: Fix some misleading indentation warnings reported by recent clang.
Summary

These should not be any functional change. While the change in
emul10kx-pcm.c looks like a real bug fix (as opposed to inconsistent
whitespace), the extra statements were not harmful.

Test Plan
  • built a mips64 MALTA64 kernel with clang/llvm from early January

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28913
Build 26903: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 25 2020, 12:54 PM
Harbormaster completed remote builds in B28913: Diff 67286.Jan 25 2020, 12:54 PM
kib accepted this revision.Jan 25 2020, 1:13 PM
This revision is now accepted and ready to land.Jan 25 2020, 1:13 PM
Closed by commit rS357146: Fix some misleading indentation warnings reported by recent clang. (authored by jhb). · Explain WhyJan 26 2020, 2:21 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS357146: Fix some misleading indentation warnings reported by recent clang..
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2020, 2:21 PM
imp added inline comments.Jan 26 2020, 5:16 PM
head/sys/kern/subr_stats.c
1588 ↗(On Diff #67314)

Sent in email, but why do we no longer clear these bits?

imp added inline comments.Jan 26 2020, 5:29 PM
head/sys/kern/subr_stats.c
1588 ↗(On Diff #67314)

Ah. See the new review to fix this so never mind

dim added a commit: rS360305: MFC r357146 (partial, by jhb):.Apr 25 2020, 1:18 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mrsas/
15 lines
sound/
pci/
11 lines
3 lines

Diff 67286

View Options

sys/dev/mrsas/mrsas_cam.c

Loading...
View Options

sys/dev/sound/pci/emu10k1.c

Loading...
View Options

sys/dev/sound/pci/emu10kx-pcm.c

Loading...