Differential D23303

Move map relookup into its own function.
ClosedPublic
Actions

Authored by jeff on Jan 21 2020, 7:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 29, 6:53 AM

	Unknown Object (File)
	Tue, Jan 28, 2:20 PM

	Unknown Object (File)
	Sat, Jan 25, 6:35 PM

	Unknown Object (File)
	Nov 1 2024, 3:39 PM

	Unknown Object (File)
	Oct 20 2024, 6:12 PM

	Unknown Object (File)
	Oct 19 2024, 5:42 AM

	Unknown Object (File)
	Oct 11 2024, 9:09 AM

	Unknown Object (File)
	Oct 4 2024, 11:34 PM

View All 68 Files

Subscribers

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357022: (fault 3/9) Move map relookup into a dedicated function.

Summary

The map revalidation is hopefully rare so we could possibly even noinline or predict_false() the call.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28833
Build 26841: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 21 2020, 7:42 PM

Harbormaster completed remote builds in B28825: Diff 67115.Jan 21 2020, 7:42 PM

jeff edited the summary of this revision. (Show Details)Jan 21 2020, 7:53 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2020, 7:53 PM

kib added inline comments.Jan 21 2020, 9:03 PM

sys/vm/vm_fault.c
810	You could reduce indent below by doing if (fs->map->timestamp == fs->map_generation) return (KERN_SUCCESS); there
826	What is KERN_RESTART ?

jeff added inline comments.Jan 21 2020, 9:06 PM

sys/vm/vm_fault.c
810	Yeah I also prefer to lessen indent and have more early returns. I can do that.
826	I meant to include that in this diff. I just added it to the list of vm errors. I am using KERN_RESOURCE_SHORTAGE to mean restart without fault_deallocate() and KERN_RESTART to mean restart with fault_deallocate(). It significantly reduces the number of places that call deallocate() and makes the error handling a little bit simpler.

Decrease indent. Remove dead comment. Add missing KERN_RESTART define.

Harbormaster completed remote builds in B28833: Diff 67128.Jan 22 2020, 2:57 AM

kib accepted this revision.Jan 22 2020, 1:14 PM

This revision is now accepted and ready to land.Jan 22 2020, 1:14 PM

markj accepted this revision.Jan 22 2020, 8:35 PM

Closed by commit rS357022: (fault 3/9) Move map relookup into a dedicated function. (authored by jeff). · Explain WhyJan 23 2020, 5:07 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS357022: (fault 3/9) Move map relookup into a dedicated function..

Revision Contents
Changeset List

Path

Size

sys/

vm/

107 lines

1 line

Diff 67128

sys/vm/vm_fault.c

Loading...

sys/vm/vm_param.h

Loading...