Differential D23283

Consistently use vm_page_valid() to validate pages.
ClosedPublic
Actions

Authored by jeff on Jan 20 2020, 6:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 10:33 PM

	Unknown Object (File)
	Fri, Oct 17, 10:33 PM

	Unknown Object (File)
	Fri, Oct 17, 10:33 PM

	Unknown Object (File)
	Fri, Oct 17, 1:15 PM

	Unknown Object (File)
	Sun, Oct 12, 10:38 AM

	Unknown Object (File)
	Wed, Oct 8, 4:30 AM

	Unknown Object (File)
	Tue, Sep 30, 1:26 PM

	Unknown Object (File)
	Sep 20 2025, 7:36 PM

View All 71 Files

Subscribers

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357017: Consistently use busy and vm_page_valid() rather than touching page bits

Summary

None of these are strictly necessary from a correctness POV. This simply makes things easier to write asserts for and reason about. Note that NOBUSY grab calls still serialize against XBUSY in case the xbusy holder is removing the page. So this is not actually introducing new serialization, it's just not released inside the grab call but instead inside the caller after the page has been set valid. I believe these are the final places in tree that directly set VM_PAGE_BITS_ALL.

In the future I may use vm_page_valid() to set a bit in the busy lock indicating validity which will allow me to optimize busy for mapping.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28794
Build 26803: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 20 2020, 6:43 PM

Harbormaster completed remote builds in B28794: Diff 67061.Jan 20 2020, 6:43 PM

jeff edited the summary of this revision. (Show Details)Jan 20 2020, 6:50 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2020, 6:50 PM

kib accepted this revision.Jan 20 2020, 9:25 PM

This revision is now accepted and ready to land.Jan 20 2020, 9:25 PM

markj accepted this revision.Jan 20 2020, 11:38 PM

Closed by commit rS357017: Consistently use busy and vm_page_valid() rather than touching page bits (authored by jeff). · Explain WhyJan 23 2020, 4:55 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS357017: Consistently use busy and vm_page_valid() rather than touching page bits.

Revision Contents
Changeset List

Path

Size

sys/

dev/

spibus/

5 lines

kern/

5 lines

kern_sendfile.c

2 lines

vm/

10 lines

15 lines

Diff 67061

sys/dev/spibus/spigen.c

Loading...

sys/kern/kern_kcov.c

Loading...

sys/kern/kern_sendfile.c

Loading...

sys/vm/vm_glue.c

Loading...

sys/vm/vm_kern.c

Loading...