Page MenuHomeFreeBSD
Differential D22994

3/7 ufs: add a setter for inode i_flag field
ClosedPublic
Actions

Authored by mjg on Jan 1 2020, 10:54 PM.
Tags
None
Referenced Files
F136909480: D22994.id66666.diff
Thu, Nov 20, 2:44 PM
F136909396: D22994.id66624.diff
Thu, Nov 20, 2:44 PM
F136909367: D22994.id.diff
Thu, Nov 20, 2:44 PM
F136909365: D22994.id66223.diff
Thu, Nov 20, 2:44 PM
F136908536: D22994.diff
Thu, Nov 20, 2:37 PM
Unknown Object (File)
Mon, Nov 3, 9:11 PM
Unknown Object (File)
Sun, Nov 2, 1:34 AM
Unknown Object (File)
Thu, Oct 30, 11:27 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jeff
mckusick
Commits
rS356669: ufs: add a setter for inode i_flag field
Summary

This will be used later for the lazy list. The change is a nop.

The diff was generated with coccinelle.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Jan 1 2020, 10:54 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 1 2020, 10:54 PM
Harbormaster completed remote builds in B28421: Diff 66223.Jan 1 2020, 10:54 PM
jeff added a reviewer: mckusick.Jan 2 2020, 8:21 PM
jeff added inline comments.
sys/ufs/ufs/inode.h
145

Possibly we should rename i_flag to prevent accidental misuse.

kib accepted this revision.Jan 2 2020, 8:57 PM
kib added inline comments.
sys/ufs/ufs/inode.h
145

Note that only setter was added. renaming the i_flag member would require a pass over readers.

This revision is now accepted and ready to land.Jan 2 2020, 8:57 PM
mjg retitled this revision from 1/5 ufs: add a setter for inode i_flag field to 3/7 ufs: add a setter for inode i_flag field.Jan 5 2020, 4:06 AM
mckusick added a comment.Jan 7 2020, 12:18 AM

What is the reason for adding this macro to set i_flags?

mjg updated this revision to Diff 66624.Jan 11 2020, 4:24 PM
mjg edited the summary of this revision. (Show Details)
  • update for r356627
This revision now requires review to proceed.Jan 11 2020, 4:24 PM
jeff accepted this revision.Jan 12 2020, 7:42 PM
This revision is now accepted and ready to land.Jan 12 2020, 7:42 PM
Closed by commit rS356669: ufs: add a setter for inode i_flag field (authored by mjg). · Explain WhyJan 13 2020, 2:32 AM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS356669: ufs: add a setter for inode i_flag field.

Revision Contents
Changeset List

PathSize
sys/
ufs/
ffs/
28 lines
20 lines
14 lines
16 lines
14 lines
2 lines
10 lines
ufs/
7 lines
4 lines
4 lines
28 lines
52 lines

Diff 66624

View Options

sys/ufs/ffs/ffs_alloc.c

Loading...
View Options

sys/ufs/ffs/ffs_balloc.c

Loading...
View Options

sys/ufs/ffs/ffs_inode.c

Loading...
View Options

sys/ufs/ffs/ffs_snapshot.c

Loading...
View Options

sys/ufs/ffs/ffs_softdep.c

Loading...
View Options

sys/ufs/ffs/ffs_vfsops.c

Loading...
View Options

sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

sys/ufs/ufs/inode.h

Loading...
View Options

sys/ufs/ufs/ufs_acl.c

Loading...
View Options

sys/ufs/ufs/ufs_inode.c

Loading...
View Options

sys/ufs/ufs/ufs_lookup.c

Loading...
View Options

sys/ufs/ufs/ufs_vnops.c

Loading...