Differential D23121

Stop prepending prefix to the result of realpath(3).
ClosedPublic
Actions

Authored by kib on Jan 10 2020, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 3:21 AM

	Unknown Object (File)
	Thu, Nov 7, 1:30 PM

	Unknown Object (File)
	Mon, Nov 4, 1:10 PM

	Unknown Object (File)
	Oct 25 2024, 11:30 PM

	Unknown Object (File)
	Sep 28 2024, 7:43 AM

	Unknown Object (File)
	Sep 27 2024, 2:57 AM

	Unknown Object (File)
	Sep 26 2024, 5:19 AM

	Unknown Object (File)
	Sep 9 2024, 3:01 AM

View All 65 Files

Subscribers

Details

Reviewers

rstone
emaste

Commits

rS356630: Stop prepending prefix to the result of realpath(3).

Summary

The path is already absolute.

Noted by: rstone

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 28590

Event Timeline

kib created this revision.Jan 10 2020, 2:13 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptJan 10 2020, 2:13 PM

Harbormaster completed remote builds in B28589: Diff 66589.Jan 10 2020, 2:13 PM

kib mentioned this in D23014: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH..Jan 10 2020, 2:14 PM

rstone added inline comments.Jan 10 2020, 2:26 PM

libexec/rtld-elf/rtld.c
5571	This will change /foo/symlink to /bar/target where we didn't before. That's not an enormous deal, but realpath will fail within a capsicum sandbox as it needs to be able to stat every component of the path, including "/". I'd prefer to only use realpath on relative paths for this reason.

kib added inline comments.Jan 10 2020, 2:48 PM

libexec/rtld-elf/rtld.c
5571	So do you want realpath(3) at all there ?

kib added inline comments.Jan 10 2020, 2:53 PM

libexec/rtld-elf/rtld.c
5571	I can test with cap_getmode(2) and only call realpath if not in cap mode. This is also a valid question for $ORIGIN resolution, where we use realpath(3) as well. See some minimal discussion with completely wrong patch at D23043.

Do not use realpath() on abs path.

Harbormaster completed remote builds in B28590: Diff 66590.Jan 10 2020, 2:54 PM

rstone accepted this revision.Jan 10 2020, 4:35 PM

This revision is now accepted and ready to land.Jan 10 2020, 4:35 PM

Closed by commit rS356630: Stop prepending prefix to the result of realpath(3). (authored by kib). · Explain WhyJan 11 2020, 9:08 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS356630: Stop prepending prefix to the result of realpath(3)..

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

27 lines

Diff 66590

libexec/rtld-elf/rtld.c

Loading...