Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH.
ClosedPublic
Actions

Authored by kib on Jan 2 2020, 11:25 PM.

Details

Reviewers

rstone
emaste

Commits

rS356548: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH.

Summary

realpath(3) was already linked into ld-elf.so.1, so I reused it there to resolve dots and dotdots making the path more canonical.

[as promised]

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 2 2020, 11:25 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptJan 2 2020, 11:25 PM

Harbormaster completed remote builds in B28449: Diff 66280.Jan 2 2020, 11:25 PM

kib retitled this revision from Resolve relative arv0 for direct exec mode to absolute path for AT_EXECPATH. to Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH..Jan 3 2020, 1:19 AM

kib edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2020, 10:00 AM

Closed by commit rS356548: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH. (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS356548: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH..

rstone added inline comments.Jan 9 2020, 7:09 PM

head/libexec/rtld-elf/rtld.c
5567	won't realpath already convert res to an absolute path? I think that this code will convert ./bar with pwd /tmp into /tmp/tmp/bar

kib added inline comments.Jan 10 2020, 2:14 PM

head/libexec/rtld-elf/rtld.c
5567	Of course you are right. Please see D23121

Revision Contents
Changeset List

Path

Size

head/

libexec/

rtld-elf/

rtld.c

36 lines

Diff 66543

View Options

head/libexec/rtld-elf/rtld.c

Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH.ClosedPublicActions