Differential D23062

Fix some issues in the linprocfs maps file.
ClosedPublic
Actions

Authored by markj on Jan 6 2020, 10:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 19, 8:06 AM

	Unknown Object (File)
	Sat, Oct 18, 7:22 PM

	Unknown Object (File)
	Sat, Oct 18, 7:22 PM

	Unknown Object (File)
	Sat, Oct 18, 7:22 PM

	Unknown Object (File)
	Sat, Oct 18, 8:56 AM

	Unknown Object (File)
	Mon, Oct 13, 1:19 PM

	Unknown Object (File)
	Mon, Oct 13, 1:28 AM

	Unknown Object (File)
	Fri, Oct 10, 8:14 PM

View All 72 Files

Subscribers

Details

Reviewers

kib
dchagin
trasz

Commits

rS356494: linprocfs: Fix some bugs in the maps file implementation.

Summary

Export the offset into the backing object, not the object size.
Fix a bug where we would print the previous entry's "offset" when a map_entry has no object.
Try to identify shared mappings. Linux prints "s" when the mapping "may be shared". This attempt is not perfect, for example, we print "p" for anonymous memory that may be shared via minherit(INHERIT_SHARE).

PR: 240992

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28512
Build 26567: arc lint + arc unit

Event Timeline

markj created this revision.Jan 6 2020, 10:50 PM

Harbormaster completed remote builds in B28512: Diff 66427.Jan 6 2020, 10:50 PM

markj added reviewers: kib, dchagin, trasz.Jan 6 2020, 10:51 PM

kib accepted this revision.Jan 7 2020, 12:13 PM

This revision is now accepted and ready to land.Jan 7 2020, 12:13 PM

Closed by commit rS356494: linprocfs: Fix some bugs in the maps file implementation. (authored by markj). · Explain WhyJan 8 2020, 4:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS356494: linprocfs: Fix some bugs in the maps file implementation..

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2020, 4:57 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linprocfs/

14 lines

Diff 66427

sys/compat/linprocfs/linprocfs.c

Loading...