Set correct lib32 MACHINE_ARCH for mips64el*.
ClosedPublic
Actions

Authored by jhb on Jan 3 2020, 9:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 28, 3:09 AM

	Unknown Object (File)
	Mon, Oct 20, 3:09 AM

	Unknown Object (File)
	Sat, Oct 18, 11:20 PM

	Unknown Object (File)
	Tue, Oct 14, 10:18 PM

	Unknown Object (File)
	Tue, Oct 14, 10:18 PM

	Unknown Object (File)
	Tue, Oct 14, 10:18 PM

	Unknown Object (File)
	Tue, Oct 14, 1:10 PM

	Unknown Object (File)
	Sep 9 2025, 6:20 AM

View All 74 Files

Subscribers

bdrewery

imp

Details

Reviewers

brooks
emaste

Commits

rS356339: Set correct lib32 MACHINE_ARCH for mips64el*.

Summary

Use "mipsel" instead of "mips" as the 32-bit MACHINE_ARCH
when building lib32 for little-endian 64-bit MIPS targets.
This fixes an error where some objects were compiled as LE
and others compiled as BE causing a link error for rtld32.

Test Plan

make buildworld TARGET_ARCH=mips64el CROSS_TOOLCHAIN=mips-gcc6 now completes instead of failing

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 3 2020, 9:29 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptJan 3 2020, 9:29 PM

Harbormaster completed remote builds in B28469: Diff 66322.Jan 3 2020, 9:29 PM

Huh.

This revision is now accepted and ready to land.Jan 3 2020, 10:01 PM

Closed by commit rS356339: Set correct lib32 MACHINE_ARCH for mips64el*. (authored by jhb). · Explain WhyJan 3 2020, 11:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356339: Set correct lib32 MACHINE_ARCH for mips64el*..

Revision Contents
Changeset List

Path

Size

head/

share/

mk/

bsd.compat.mk

3 lines

Diff 66327

View Options

head/share/mk/bsd.compat.mk

Set correct lib32 MACHINE_ARCH for mips64el*.ClosedPublicActions