Fix AT_EXECPATH for direct exec mode.
ClosedPublic
Actions

Authored by kib on Dec 20 2019, 10:12 PM.

Details

Reviewers

rstone
emaste

Commits

rS356300: Fix AT_EXECPATH for direct exec mode.

Summary

The somewhat problematic case is when the executable path is relative and either $PATH use is not enabled or it contains '/' so $PATH search is not performed. In this case AT_EXECPATH is relative, I might fix this later.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 20 2019, 10:12 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptDec 20 2019, 10:12 PM

Harbormaster completed remote builds in B28271: Diff 65874.Dec 20 2019, 10:12 PM

rstone added inline comments.Dec 21 2019, 2:57 AM

libexec/rtld-elf/rtld.c
510 ↗	(On Diff #65874)	Testing has shown that aux_info[AT_EXECPATH] is not guaranteed to be non-NULL

Handle a case when AT_EXECPATH is not present in auxv.
Add XXX comments.

Harbormaster completed remote builds in B28275: Diff 65889.Dec 21 2019, 10:38 AM

Remove pointless reassignment.

Harbormaster completed remote builds in B28276: Diff 65891.Dec 21 2019, 2:53 PM

rstone accepted this revision.Jan 2 2020, 5:13 PM

This revision is now accepted and ready to land.Jan 2 2020, 5:13 PM

Closed by commit rS356300: Fix AT_EXECPATH for direct exec mode. (authored by kib). · Explain WhyJan 2 2020, 10:48 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS356300: Fix AT_EXECPATH for direct exec mode..

Revision Contents
Changeset List

Path

Size

head/

libexec/

rtld-elf/

rtld.c

33 lines

Diff 66275

View Options

head/libexec/rtld-elf/rtld.c

Fix AT_EXECPATH for direct exec mode.ClosedPublicActions