Differential D22946

vmgenid(4): Integrate as a random(4) source
ClosedPublic
Actions

Authored by cem on Dec 28 2019, 8:01 PM.

Tags

None

Referenced Files

	F142201903: D22946.diff
	Sat, Jan 17, 4:22 AM

	F142141247: D22946.id66199.diff
	Fri, Jan 16, 10:32 AM

	Unknown Object (File)
	Wed, Jan 14, 11:46 AM

	Unknown Object (File)
	Sun, Jan 11, 1:54 AM

	Unknown Object (File)
	Sun, Jan 11, 1:54 AM

	Unknown Object (File)
	Sun, Jan 11, 1:54 AM

	Unknown Object (File)
	Wed, Dec 24, 9:44 PM

	Unknown Object (File)
	Fri, Dec 19, 5:17 PM

Subscribers

Details

Reviewers

whu
markm
jmg

Group Reviewers

csprng
O3: Kernel Random Numbers Generator

Commits

rS356245: vmgenid(4): Integrate as a random(4) source

Summary

The number is currently published by the vmgenid(4) driver and has no
"entropy," but should be integrated quickly on VM rewind events to avoid
duplicate sequences.

Test Plan

(If we think the entropy would be more valuable, we could restrict
publication of the GUID from vmgenid(4). I do not know if it is available
to unprivileged users in any other way.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Dec 28 2019, 8:01 PM

Harbormaster completed remote builds in B28353: Diff 66073.Dec 28 2019, 8:01 PM

LGTM

This revision is now accepted and ready to land.Dec 29 2019, 10:27 AM

Closed by commit rS356245: vmgenid(4): Integrate as a random(4) source (authored by cem). · Explain WhyJan 1 2020, 12:35 AM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS356245: vmgenid(4): Integrate as a random(4) source.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Jan 1 2020, 12:35 AM

Herald added a reviewer: jmg. · View Herald TranscriptJan 1 2020, 12:35 AM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

Packages

head/

sys/

dev/

random/

7 lines

O3: Kernel Random Numbers Generator

random_harvestq.c

1 line

O3: Kernel Random Numbers Generator

vmgenc/

22 lines

sys/

1 line

Diff 66199

head/sys/dev/random/fortuna.c

Loading...

head/sys/dev/random/random_harvestq.c

Loading...

head/sys/dev/vmgenc/vmgenc_acpi.c

Loading...

head/sys/sys/random.h

Loading...