RISC-V: Don't hard-code field offsets of struct riscv_bootparams
ClosedPublic
Actions

Authored by jrtc27 on Dec 30 2019, 3:12 PM.

Tags

None

Referenced Files

	F171035667: D22970.id66145.diff
	Tue, Sep 8, 7:55 AM

	F170994736: D22970.id66145.diff
	Tue, Sep 8, 2:02 AM

	Unknown Object (File)
	Wed, Sep 2, 10:30 AM

	Unknown Object (File)
	Wed, Sep 2, 9:47 AM

	Unknown Object (File)
	Wed, Sep 2, 1:21 AM

	Unknown Object (File)
	Fri, Aug 21, 7:35 PM

	Unknown Object (File)
	Thu, Aug 20, 3:26 PM

	Unknown Object (File)
	Wed, Aug 19, 3:48 PM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rS356205: Don't hard-code field offsets of struct riscv_bootparams.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28381
Build 26466: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Dec 30 2019, 3:12 PM

Harbormaster completed remote builds in B28380: Diff 66142.Dec 30 2019, 3:12 PM

br added inline comments.Dec 30 2019, 4:35 PM

sys/riscv/riscv/genassym.c
106	This line does not fit my terminal

Wrapped >80-character line.

Harbormaster completed remote builds in B28381: Diff 66144.Dec 30 2019, 4:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2019, 5:19 PM

Closed by commit rS356205: Don't hard-code field offsets of struct riscv_bootparams. (authored by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rS356205: Don't hard-code field offsets of struct riscv_bootparams..

Herald added a subscriber: imp. · View Herald TranscriptDec 30 2019, 5:19 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

genassym.c

6 lines

locore.S

10 lines

Diff 66144

View Options

sys/riscv/riscv/genassym.c