Page MenuHomeFreeBSD
Differential D22970

RISC-V: Don't hard-code field offsets of struct riscv_bootparams
ClosedPublic
Actions

Authored by jrtc27 on Dec 30 2019, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:04 AM
Unknown Object (File)
Sep 24 2024, 9:08 AM
Unknown Object (File)
Sep 23 2024, 8:43 AM
Unknown Object (File)
Sep 22 2024, 2:20 PM
Unknown Object (File)
Sep 15 2024, 10:28 PM
Unknown Object (File)
Sep 5 2024, 11:05 AM
Unknown Object (File)
Sep 1 2024, 2:21 AM
Unknown Object (File)
Aug 26 2024, 7:44 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
br
Commits
rS356205: Don't hard-code field offsets of struct riscv_bootparams.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28381
Build 26466: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Dec 30 2019, 3:12 PM
Harbormaster completed remote builds in B28380: Diff 66142.Dec 30 2019, 3:12 PM
br added inline comments.Dec 30 2019, 4:35 PM
sys/riscv/riscv/genassym.c
106

This line does not fit my terminal

jrtc27 updated this revision to Diff 66144.Dec 30 2019, 4:53 PM

Wrapped >80-character line.

Harbormaster completed remote builds in B28381: Diff 66144.Dec 30 2019, 4:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2019, 5:19 PM
Closed by commit rS356205: Don't hard-code field offsets of struct riscv_bootparams. (authored by br). · Explain Why
This revision was automatically updated to reflect the committed changes.
br added a commit: rS356205: Don't hard-code field offsets of struct riscv_bootparams..
Herald added a subscriber: imp. · View Herald TranscriptDec 30 2019, 5:19 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
6 lines
10 lines

Diff 66144

View Options

sys/riscv/riscv/genassym.c

Loading...
View Options

sys/riscv/riscv/locore.S

Loading...