Page MenuHomeFreeBSD
Differential D22970

RISC-V: Don't hard-code field offsets of struct riscv_bootparams
ClosedPublic
Actions

Authored by jrtc27 on Dec 30 2019, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 9:01 AM
Unknown Object (File)
Thu, Nov 20, 7:50 PM
Unknown Object (File)
Thu, Nov 20, 7:46 PM
Unknown Object (File)
Thu, Nov 20, 7:46 PM
Unknown Object (File)
Thu, Nov 20, 7:45 PM
Unknown Object (File)
Thu, Nov 20, 7:37 PM
Unknown Object (File)
Tue, Nov 18, 11:12 PM
Unknown Object (File)
Sun, Nov 16, 10:07 PM
View All 88 Files
Subscribers
imp

Details

Reviewers
br
Commits
rS356205: Don't hard-code field offsets of struct riscv_bootparams.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28381
Build 26466: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Dec 30 2019, 3:12 PM
Harbormaster completed remote builds in B28380: Diff 66142.Dec 30 2019, 3:12 PM
br added inline comments.Dec 30 2019, 4:35 PM
sys/riscv/riscv/genassym.c
106

This line does not fit my terminal

jrtc27 updated this revision to Diff 66144.Dec 30 2019, 4:53 PM

Wrapped >80-character line.

Harbormaster completed remote builds in B28381: Diff 66144.Dec 30 2019, 4:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2019, 5:19 PM
Closed by commit rS356205: Don't hard-code field offsets of struct riscv_bootparams. (authored by br). · Explain Why
This revision was automatically updated to reflect the committed changes.
br added a commit: rS356205: Don't hard-code field offsets of struct riscv_bootparams..
Herald added a subscriber: imp. · View Herald TranscriptDec 30 2019, 5:19 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
6 lines
10 lines

Diff 66144

View Options

sys/riscv/riscv/genassym.c

Loading...
View Options

sys/riscv/riscv/locore.S

Loading...