sysctlbyname(2): Remove temporary compatibility layer
ClosedPublic
Actions

Authored by kaktus on Dec 29 2019, 3:04 PM.

Details

Reviewers

mjg
kib
imp

Commits

rS356179: sysctlbyname(2): Remove temporary compatibility layer

Summary

Remove temporary compatibility layer introduced in r351729. More that 3 months should be enough for everybody who runs HEAD to upgrade to the new kernel already.

Approved-by:
Reviewed-by:

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Dec 29 2019, 3:04 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2019, 3:04 PM

Remove the now unneeded include of libc_private.h too.

mjg accepted this revision.Dec 29 2019, 3:25 PM

This revision is now accepted and ready to land.Dec 29 2019, 3:25 PM

Will this break stable/12 binaries on cuurent?

This revision now requires changes to proceed.Dec 29 2019, 3:40 PM

No. This was only in place to make sure people can rollback to older kernel without libc exploding.

mjg requested changes to this revision.Dec 29 2019, 3:55 PM

mjg accepted this revision.

% file 12.1/bin/df
12.1/bin/df: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.1, FreeBSD-style, stripped

% truss -o /dev/stdout ./12.1/bin/df -l | grep sysctlby
__sysctlbyname("vfs.conflist",12,0x0,0x7fffffffcdf8,0x0,0) = 0 (0x0)
__sysctlbyname("vfs.conflist",12,0x8006eb000,0x7fffffffcdf8,0x0,0) = 0 (0x0)

Ok. In that case we are good.

This revision is now accepted and ready to land.Dec 29 2019, 4:52 PM

Closed by commit rS356179: sysctlbyname(2): Remove temporary compatibility layer (authored by kaktus). · Explain WhyDec 29 2019, 5:20 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS356179: sysctlbyname(2): Remove temporary compatibility layer.