Page MenuHomeFreeBSD
Differential D22950

Report block devices as such to Linux binaries
ClosedPublic
Actions

Authored by trasz on Dec 28 2019, 10:38 PM.
Tags
None
Referenced Files
F106062704: D22950.diff
Tue, Dec 24, 6:26 PM
Unknown Object (File)
Sun, Dec 22, 8:42 PM
Unknown Object (File)
Fri, Dec 13, 8:57 AM
Unknown Object (File)
Sat, Nov 30, 3:31 AM
Unknown Object (File)
Oct 28 2024, 2:46 AM
Unknown Object (File)
Sep 21 2024, 5:20 AM
Unknown Object (File)
Sep 20 2024, 2:22 PM
Unknown Object (File)
Sep 20 2024, 12:55 AM
View All 36 Files
Subscribers
imp

Details

Reviewers
emaste
dchagin
kib
Group Reviewers
Linux Emulation
Commits
rS356172: Make Linux stat(2) et al distinguish between block and character
Summary

Make Linux stat(2) et al distinguish between block and character
devices. It's required for LTP, among other things. It's not
complete, but good enough for now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28363
Build 26450: arc lint + arc unit

Event Timeline

trasz created this revision.Dec 28 2019, 10:38 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2019, 10:38 PM
Harbormaster completed remote builds in B28354: Diff 66080.Dec 28 2019, 10:38 PM
trasz added reviewers: Linux Emulation, emaste, dchagin, kib.Dec 28 2019, 10:38 PM
kib added inline comments.Dec 28 2019, 10:59 PM
sys/compat/linux/linux_stats.c
68

VCHR check is excessive

121–125

At least this lacks a check that vp != NULL, see a line just below the added chunk.

trasz updated this revision to Diff 66094.Dec 29 2019, 11:25 AM

Fixes from kib@.

Harbormaster completed remote builds in B28363: Diff 66094.Dec 29 2019, 11:25 AM
trasz marked 2 inline comments as done.Dec 29 2019, 11:25 AM
kib accepted this revision.Dec 29 2019, 12:32 PM
This revision is now accepted and ready to land.Dec 29 2019, 12:32 PM
Closed by commit rS356172: Make Linux stat(2) et al distinguish between block and character (authored by trasz). · Explain WhyDec 29 2019, 1:54 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS356172: Make Linux stat(2) et al distinguish between block and character.
dchagin added a comment.Jun 17 2022, 10:44 AM

Hi, could you please describe which LTP tests fails? I have implemented xattr support (rsync uses this) and see that some xattr tests fails due to the mknod/openat pair fails if node is created with IFBLK.

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
9 lines

Diff 66094

View Options

sys/compat/linux/linux_stats.c

Loading...