Differential D22946

vmgenid(4): Integrate as a random(4) source
ClosedPublic
Actions

Authored by cem on Dec 28 2019, 8:01 PM.

Tags

None

Referenced Files

	F167914066: D22946.diff
	Tue, Aug 25, 10:02 AM

	F167907856: D22946.id.diff
	Tue, Aug 25, 9:23 AM

	Unknown Object (File)
	Sat, Aug 22, 10:33 AM

	Unknown Object (File)
	Thu, Aug 13, 10:53 PM

	Unknown Object (File)
	Wed, Aug 12, 7:18 PM

	Unknown Object (File)
	Tue, Aug 11, 7:09 AM

	Unknown Object (File)
	Mon, Aug 10, 10:06 AM

	Unknown Object (File)
	Mon, Aug 10, 6:20 AM

Subscribers

Details

Reviewers

whu
markm
jmg

Group Reviewers

csprng
O3: Kernel Random Numbers Generator	(Owns No Changed Paths)

Commits

rS356245: vmgenid(4): Integrate as a random(4) source

Summary

The number is currently published by the vmgenid(4) driver and has no
"entropy," but should be integrated quickly on VM rewind events to avoid
duplicate sequences.

Test Plan

(If we think the entropy would be more valuable, we could restrict
publication of the GUID from vmgenid(4). I do not know if it is available
to unprivileged users in any other way.)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28353
Build 26444: arc lint + arc unit

Event Timeline

cem created this revision.Dec 28 2019, 8:01 PM

Harbormaster completed remote builds in B28353: Diff 66073.Dec 28 2019, 8:01 PM

LGTM

This revision is now accepted and ready to land.Dec 29 2019, 10:27 AM

Closed by commit rS356245: vmgenid(4): Integrate as a random(4) source (authored by cem). · Explain WhyJan 1 2020, 12:35 AM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS356245: vmgenid(4): Integrate as a random(4) source.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Jan 1 2020, 12:35 AM

Herald added a reviewer: jmg. · View Herald TranscriptJan 1 2020, 12:35 AM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

dev/

random/

7 lines

random_harvestq.c

1 line

vmgenc/

22 lines

sys/

1 line

Diff 66073

sys/dev/random/fortuna.c

Loading...

sys/dev/random/random_harvestq.c

Loading...

sys/dev/vmgenc/vmgenc_acpi.c

Loading...

sys/sys/random.h

Loading...