Differential D22868

Fix VPO_UNMANAGED handling in vm_page_reclaim_run().
ClosedPublic
Actions

Authored by markj on Dec 18 2019, 6:40 PM.

Tags

None

Referenced Files

	F137411541: D22868.id65786.diff
	Sun, Nov 23, 5:12 AM

	Unknown Object (File)
	Thu, Nov 20, 11:59 PM

	Unknown Object (File)
	Thu, Nov 20, 11:58 PM

	Unknown Object (File)
	Thu, Nov 20, 11:54 PM

	Unknown Object (File)
	Thu, Nov 20, 11:53 PM

	Unknown Object (File)
	Thu, Nov 20, 11:48 PM

	Unknown Object (File)
	Thu, Nov 20, 12:55 PM

	Unknown Object (File)
	Wed, Nov 19, 4:11 PM

Subscribers

Details

Reviewers

alc
kib
dougm
jeff

Commits

rS355985: Fix VPO_UNMANAGED handling in vm_page_reclaim_run() after r353540.

Summary

When we allocate a replacement page we must clear VPO_UNMANAGED, since
we only ever reclaim pages from managed objects. vm_page_replace() does
not handle this for us.

Sprinkle some assertions to help catch this sort of issue.

Test Plan

Peter is testing this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 18 2019, 6:40 PM

Harbormaster completed remote builds in B28217: Diff 65786.Dec 18 2019, 6:40 PM

markj edited the test plan for this revision. (Show Details)Dec 18 2019, 6:40 PM

markj added reviewers: alc, kib, dougm, jeff.

kib accepted this revision.Dec 18 2019, 9:26 PM

kib added inline comments.

sys/vm/vm_page.c
3676 ↗	(On Diff #65786)	I think this assert is not useful, it is tautologically repeats the condition that resulted in this branch.
3680 ↗	(On Diff #65786)	same

This revision is now accepted and ready to land.Dec 18 2019, 9:26 PM

markj added inline comments.Dec 18 2019, 9:30 PM

sys/vm/vm_page.c
3676 ↗	(On Diff #65786)	Ugh, for some reason I read the condition as (m->object->flags & OBJ_UNMANAGED) == 0.

Add a non-tautological assertion to vm_page_free_prep().

This revision now requires review to proceed.Dec 18 2019, 9:38 PM

Harbormaster completed remote builds in B28221: Diff 65794.Dec 18 2019, 9:38 PM

kib accepted this revision.Dec 18 2019, 9:46 PM

This revision is now accepted and ready to land.Dec 18 2019, 9:46 PM

alc accepted this revision.Dec 18 2019, 10:21 PM

Closed by commit rS355985: Fix VPO_UNMANAGED handling in vm_page_reclaim_run() after r353540. (authored by markj). · Explain WhyDec 21 2019, 7:04 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS355985: Fix VPO_UNMANAGED handling in vm_page_reclaim_run() after r353540..

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2019, 7:04 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

11 lines

Diff 65894

head/sys/vm/vm_page.c

Loading...