Differential D22833

[PowerPC64] Enable virtio drivers
ClosedPublic
Actions

Authored by alfredo on Dec 16 2019, 12:37 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Oct 18, 2:48 AM

	Unknown Object (File)
	Fri, Oct 17, 4:28 AM

	Unknown Object (File)
	Thu, Oct 16, 2:18 PM

	Unknown Object (File)
	Thu, Oct 16, 2:18 PM

	Unknown Object (File)
	Thu, Oct 16, 2:18 PM

	Unknown Object (File)
	Thu, Oct 16, 2:18 PM

	Unknown Object (File)
	Thu, Oct 16, 2:18 PM

	Unknown Object (File)
	Thu, Oct 16, 2:36 AM

Subscribers

afscoelho_gmail.com

Details

Reviewers

Group Reviewers

Commits

rS356788: [PowerPC64] Enable virtio drivers

Summary

This enables virtio modules on PowerPC* target.
On PowerPC64, drivers are also kernel builtin.

QEMU currently needs to be patched to in order to work on LE hosts due to known issue affecting pre-1.0 (legacy) virtio drivers.
The patch was submitted to QEMU mail list by @afscoelho_gmail.com, available at https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg01496.html

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28182
Build 26311: arc lint + arc unit

Event Timeline

alfredo created this revision.Dec 16 2019, 12:37 PM

Herald added subscribers: luporl, bdragon, jhibbits. · View Herald TranscriptDec 16 2019, 12:37 PM

Harbormaster completed remote builds in B28175: Diff 65705.Dec 16 2019, 12:37 PM

alfredo added a reviewer: PowerPC.Dec 16 2019, 1:36 PM

jhibbits added inline comments.Dec 16 2019, 4:48 PM

sys/modules/Makefile
770	I've tested that your patched virtio drivers (from your abandoned review) work on powerpcspe as well, so why not put this under the MACHINE_CPUARCH == powerpc banner?

build virtio modules on all powerpc platforms

Harbormaster completed remote builds in B28179: Diff 65710.Dec 16 2019, 6:06 PM

alfredo marked an inline comment as done.Dec 16 2019, 6:06 PM

enable man pages as suggested by @bdragon

Harbormaster completed remote builds in B28182: Diff 65715.Dec 16 2019, 7:08 PM

alfredo edited the summary of this revision. (Show Details)Jan 8 2020, 6:06 PM

alfredo added a subscriber: afscoelho_gmail.com.

LGTM.
I've tested this by applying the QEMU patch over version 4.2.0 and everything worked fine.

This revision is now accepted and ready to land.Jan 14 2020, 4:35 PM

Closed by commit rS356788: [PowerPC64] Enable virtio drivers (authored by luporl). · Explain WhyJan 16 2020, 11:33 AM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS356788: [PowerPC64] Enable virtio drivers.

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2020, 11:33 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

8 lines

sys/

modules/

1 line

powerpc/

conf/

9 lines

Diff 65715

share/man/man4/Makefile

Loading...

sys/modules/Makefile

Loading...

sys/powerpc/conf/GENERIC64

Loading...