Page MenuHomeFreeBSD

Eliminate lock recursion from turnstiles.
ClosedPublic

Authored by jeff on Dec 10 2019, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 21, 3:19 PM
Unknown Object (File)
Jul 1 2025, 10:31 AM
Unknown Object (File)
Jun 30 2025, 5:21 AM
Unknown Object (File)
Jun 27 2025, 9:04 AM
Unknown Object (File)
Jun 25 2025, 3:09 AM
Unknown Object (File)
Jun 23 2025, 3:41 AM
Unknown Object (File)
Jun 21 2025, 11:20 PM
Unknown Object (File)
Jun 20 2025, 9:02 PM
Subscribers

Details

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff added reviewers: jhb, kib, mav.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS355782: schedlock 3/4.