Page MenuHomeFreeBSD

Eliminate lock recursion from turnstiles.
ClosedPublic

Authored by jeff on Dec 10 2019, 6:16 AM.
Tags
None
Referenced Files
F103248287: D22746.diff
Fri, Nov 22, 3:04 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 12:45 PM
Unknown Object (File)
Sep 27 2024, 2:22 AM
Unknown Object (File)
Sep 26 2024, 6:26 PM
Unknown Object (File)
Sep 22 2024, 6:57 PM
Subscribers

Details

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28055
Build 26203: arc lint + arc unit

Event Timeline

jeff added reviewers: jhb, kib, mav.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS355782: schedlock 3/4.