This patch enables moving WWW from pkg-descr to Makefile. The additional script change-www will merge WWW value from pkg-descr to Makefile in a single go.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I do like the script very much, unfortunatly I have been bitten in the past by such scripts, they would work 99% of cases but not 100% so you will have to review manually the diff so going category by category is a step to go imho.
Your script does not seems to take in account mutliple WWW entries, imho it should transform them into:
WWW= site1 site2
or
WWW= site1 \
site2
That said I do like this script.
BTW bsd.port.mk should be patched to use WWW if defined (but keep a fallback for compatibiblity)
make index should be checked as well.
An announce should be sent before the migration to give time for third party (freshports?) application to update
I would like to hear what other portmgr thinks about that change
(FYI @bofh took the project from my TODO list :)) https://wiki.freebsd.org/Ports/BaptTODO
Comment Actions
First of all thank for the great appreciation of the script. Yes this script is not full proof. As you have mentioned about multiple WWW entries. Starting from 2 I can see something using 4 WWW entries too. \n would be a bad idea I believe as in the INDEX it adds a single line for a single port. So adding a different separator other than \n and | is expected. It will depend based on the advice from all of us.
And yes it will require some manual intervention hence we might consider commiting category by category with a slow go. My patch for bsd.port.mk keeps a fallback compatibility for the interim period. After moving to Makefile we can get rid of that part too.